Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vault: 0.9.5 -> 0.10.3 #43355

Merged
merged 1 commit into from Jul 11, 2018
Merged

vault: 0.9.5 -> 0.10.3 #43355

merged 1 commit into from Jul 11, 2018

Conversation

bricewge
Copy link
Contributor

Motivation for this change

Keeping up-to-date with upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bricewge
vault: 0.9.5 -> 0.10.3
2af4a45 
Signed-off-by: Brice Waegeneire <brice.wge@gmail.com>
@xeji
Copy link
Contributor

xeji commented Jul 11, 2018

@GrahamcOfBorg build vault

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vault

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2md49i7dlv5jy8sgyfnv98shy77svl1b-vault-0.10.3
shrinking /nix/store/2md49i7dlv5jy8sgyfnv98shy77svl1b-vault-0.10.3/bin/vault
cannot find section .dynamic
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2md49i7dlv5jy8sgyfnv98shy77svl1b-vault-0.10.3/bin 
patching script interpreter paths in /nix/store/2md49i7dlv5jy8sgyfnv98shy77svl1b-vault-0.10.3
checking for references to /tmp/nix-build-vault-0.10.3.drv-0 in /nix/store/2md49i7dlv5jy8sgyfnv98shy77svl1b-vault-0.10.3...
cannot find section .dynamic
/nix/store/2md49i7dlv5jy8sgyfnv98shy77svl1b-vault-0.10.3

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: vault

Partial log (click to expand)

==> Checking that build is using go version >= 1.10...
go generate
==> Removing old directory...
==> Building...
No valid platforms to build for. If you specified a value
for the 'os', 'arch', or 'osarch' flags, make sure you're
using a valid value.
make: *** [Makefile:28: dev] Error 1
builder for '/nix/store/i4df8z7l23ndr0s33jbwm2s7918bnjzh-vault-0.10.3.drv' failed with exit code 2
error: build of '/nix/store/i4df8z7l23ndr0s33jbwm2s7918bnjzh-vault-0.10.3.drv' failed

@xeji
Copy link
Contributor

xeji commented Jul 11, 2018

I was a little surprised to see the resulting binary is 60M large.

@bricewge
Copy link
Contributor Author

That's definitely on the big size... But the version in 18.03 is currently at 56M so it don't came from this PR.

@xeji
Copy link
Contributor

xeji commented Jul 11, 2018

Well, it's about the same size in the Arch package. Disk space is so cheap nobody cares anymore 🙁

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: vault

Partial log (click to expand)


==> Results:
total 86M
-rwxr-xr-x 1 nixbld1 nixbld 86M Jul 11 19:48 vault
installing
post-installation fixup
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/4xh5dmcnki5i5z82m80hrwc7cdav4vfr-vault-0.10.3/bin
patching script interpreter paths in /nix/store/4xh5dmcnki5i5z82m80hrwc7cdav4vfr-vault-0.10.3
/nix/store/4xh5dmcnki5i5z82m80hrwc7cdav4vfr-vault-0.10.3

@xeji xeji merged commit 9ae92ee into NixOS:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bricewge @xeji @GrahamcOfBorg