Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubygems: 2.7.6 -> 2.7.7 and update src URL to official HTTPS location #45275

Merged
merged 2 commits into from Aug 19, 2018
Merged

rubygems: 2.7.6 -> 2.7.7 and update src URL to official HTTPS location #45275

merged 2 commits into from Aug 19, 2018

Conversation

mbbx6spp
Copy link
Contributor

Motivation for this change

Rubygems 2.7.7 was released in May[1] which fixes some bugs. I also updated the src's URL to use the official HTTPS location in a separate commit in this PR branch.

[1] https://blog.rubygems.org/2018/05/18/2.7.7-released.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • N/A [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/): tested ./result/bin/ruby --version
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md: I created a separate commit for changing the URL location for the source to the official HTTPS location for the archive and created appropriate commit messages for both changes.

@mbbx6spp mbbx6spp requested a review from zimbatm as a code owner August 17, 2018 17:31
@NeQuissimus
Copy link
Member

@GrahamcOfBorg build ruby_2_3 ruby_2_4 ruby_2_5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ruby_2_3, ruby_2_4, ruby_2_5

Partial log (click to expand)

shrinking /nix/store/fc4jxydj08gw2f39gm8rml0hjiwp5sj9-ruby-2.5.1/lib/libruby.so.2.5.1
shrinking /nix/store/fc4jxydj08gw2f39gm8rml0hjiwp5sj9-ruby-2.5.1/bin/ruby
gzipping man pages under /nix/store/fc4jxydj08gw2f39gm8rml0hjiwp5sj9-ruby-2.5.1/share/man/
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fc4jxydj08gw2f39gm8rml0hjiwp5sj9-ruby-2.5.1/lib  /nix/store/fc4jxydj08gw2f39gm8rml0hjiwp5sj9-ruby-2.5.1/bin
patching script interpreter paths in /nix/store/fc4jxydj08gw2f39gm8rml0hjiwp5sj9-ruby-2.5.1
checking for references to /build in /nix/store/fc4jxydj08gw2f39gm8rml0hjiwp5sj9-ruby-2.5.1...
/nix/store/zvmm6sc0514xp52rf8c8273q2kywwf72-ruby-2.3.7
/nix/store/q2bc62qv62ws93i0q24a6yc13xcrnb3m-ruby-2.4.4
/nix/store/fc4jxydj08gw2f39gm8rml0hjiwp5sj9-ruby-2.5.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ruby_2_3, ruby_2_4, ruby_2_5

Partial log (click to expand)

/nix/store/6502s2wn555qnz26jkgbc56nr6fc3pm8-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/6502s2wn555qnz26jkgbc56nr6fc3pm8-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/6502s2wn555qnz26jkgbc56nr6fc3pm8-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/6502s2wn555qnz26jkgbc56nr6fc3pm8-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/6502s2wn555qnz26jkgbc56nr6fc3pm8-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/6502s2wn555qnz26jkgbc56nr6fc3pm8-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/6502s2wn555qnz26jkgbc56nr6fc3pm8-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/aca8j596l1jx8wfs32as2p7x6dj7l8lg-ruby-2.3.7
/nix/store/bw3qwixsjn6yxzq35yn25kp5djbl8h41-ruby-2.4.4
/nix/store/6502s2wn555qnz26jkgbc56nr6fc3pm8-ruby-2.5.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ruby_2_3, ruby_2_4, ruby_2_5

Partial log (click to expand)

shrinking /nix/store/4j0mh1wm9d8jqy522hlmihak1ifz3dn2-ruby-2.4.4/lib/ruby/2.4.0/aarch64-linux/ripper.so
shrinking /nix/store/4j0mh1wm9d8jqy522hlmihak1ifz3dn2-ruby-2.4.4/lib/ruby/2.4.0/aarch64-linux/socket.so
gzipping man pages under /nix/store/4j0mh1wm9d8jqy522hlmihak1ifz3dn2-ruby-2.4.4/share/man/
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4j0mh1wm9d8jqy522hlmihak1ifz3dn2-ruby-2.4.4/lib  /nix/store/4j0mh1wm9d8jqy522hlmihak1ifz3dn2-ruby-2.4.4/bin
patching script interpreter paths in /nix/store/4j0mh1wm9d8jqy522hlmihak1ifz3dn2-ruby-2.4.4
checking for references to /build in /nix/store/4j0mh1wm9d8jqy522hlmihak1ifz3dn2-ruby-2.4.4...
/nix/store/swx1jsqs8ybpkckp27ih5sn9mlyz8xqg-ruby-2.3.7
/nix/store/4j0mh1wm9d8jqy522hlmihak1ifz3dn2-ruby-2.4.4
/nix/store/cqv6y23hgh5hmbyl7ghsrn82zvk44j47-ruby-2.5.1

@NeQuissimus NeQuissimus merged commit 8ac2559 into NixOS:master Aug 19, 2018
@mbbx6spp mbbx6spp deleted the update/rubygems-276-to-277 branch August 27, 2018 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbbx6spp @NeQuissimus @GrahamcOfBorg