New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aravis: init at 0.5.13 #45274
aravis: init at 0.5.13 #45274
Conversation
47da4c6
to
ddb7ead
Compare
version = "0.5.13"; | ||
name = "${pname}-${version}"; | ||
|
||
src = fetchurl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use fetchFromGitHub
instead of fetchurl
because it relies on the hash of the contents of the repository instead of the hash of a tarball, and it would allow us to fix all GitHub src fetchers, if GitHub changes something about how it works.
@GrahamcOfBorg build aravis |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: aravis Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: aravis Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: aravis Partial log (click to expand)
|
@rehno-lindeque we'll need the changes asked by @ryantm to merge this :). |
Sorry, I'll try to finish up in a couple of days |
ddb7ead
to
0db3d33
Compare
Sorry for the long wait, EDIT: also renamed |
0db3d33
to
4ef6ce5
Compare
@ryantm look ok? |
@GrahamcOfBorg build aravis |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: aravis Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: aravis Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: aravis Partial log (click to expand)
|
@rehno-lindeque Merged; thanks for pushing this through! |
Motivation for this change
aravis is a library for interacting with GenICam (industrial) cameras. It is primarily a library but also comes with a viewer application.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)