Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pius: introduce perl as buildInput #44415

Merged
merged 1 commit into from Aug 3, 2018
Merged

pius: introduce perl as buildInput #44415

merged 1 commit into from Aug 3, 2018

Conversation

erictapen
Copy link
Member

Otherwise, pius-party-worksheet would be unusable.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@erictapen
pius: introduce perl as buildInput
e994228 
Otherwise, pius-party-worksheet would be unusable.
@xeji
Copy link
Contributor

xeji commented Aug 3, 2018

@GrahamcOfBorg build pius

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pius

Partial log (click to expand)

writing dependency_links to pius.egg-info/dependency_links.txt
reading manifest file 'pius.egg-info/SOURCES.txt'
writing manifest file 'pius.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/q19qw1qwfq1haypk79dkkfcx967scdpy-pius-2.2.4

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pius

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pius

Partial log (click to expand)

writing dependency_links to pius.egg-info/dependency_links.txt
reading manifest file 'pius.egg-info/SOURCES.txt'
writing manifest file 'pius.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/m3sc3k9qml8n3hzi9arrajf8brqwmq76-pius-2.2.4

@xeji xeji merged commit 4dbf327 into NixOS:release-18.03 Aug 3, 2018
@xeji
Copy link
Contributor

xeji commented Aug 3, 2018

@erictapen would this change apply to the version in master as well?

@erictapen
Copy link
Member Author

erictapen commented Aug 3, 2018 •
edited

@xeji Yes, this applies as well. Will you cherry-pick or should I provide another PR?

master has even more problems, as pius can't find a python module, but I did not find an easy solution to that.

@xeji
Copy link
Contributor

xeji commented Aug 3, 2018 •
edited

I'll pick it to master later. (BTW, our preferred workflow in such a case is to open a PR against master and mention that it needs backporting).

@erictapen
Copy link
Member Author

Thanks and good to know. Will apply that next time.

@erictapen erictapen deleted the pius-fixup branch August 3, 2018 17:30
@xeji
Copy link
Contributor

xeji commented Aug 3, 2018

picked to master in b8da5fc

xeji pushed a commit that referenced this pull request Aug 3, 2018
@erictapen @xeji
pius: introduce perl as buildInput (#44415)
b8da5fc 
Otherwise, pius-party-worksheet would be unusable.

(cherry picked from commit 4dbf327)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erictapen @xeji @GrahamcOfBorg