Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

antlr: explicitly use python2 #44416

Merged
merged 1 commit into from Aug 3, 2018
Merged

antlr: explicitly use python2 #44416

merged 1 commit into from Aug 3, 2018

Conversation

dotlambda
Copy link
Member

Also, put python2 into nativeBuildInputs because Arch lists it in makedepends.

Motivation for this change

#18185

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

antlr: explicitly use python2
f0702c6 
Also, put python2 into nativeBuildInputs because Arch lists it in makedepends.
@dotlambda dotlambda changed the title antlr2: explicitly use python2 antlr: explicitly use python2 Aug 3, 2018
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: antlr

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: antlr

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ccdzqjfb2x03gk6vq78y457s9cpps9cm-antlr-2.7.7
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ccdzqjfb2x03gk6vq78y457s9cpps9cm-antlr-2.7.7/lib  /nix/store/ccdzqjfb2x03gk6vq78y457s9cpps9cm-antlr-2.7.7/bin  /nix/store/ccdzqjfb2x03gk6vq78y457s9cpps9cm-antlr-2.7.7/sbin
patching script interpreter paths in /nix/store/ccdzqjfb2x03gk6vq78y457s9cpps9cm-antlr-2.7.7
/nix/store/ccdzqjfb2x03gk6vq78y457s9cpps9cm-antlr-2.7.7/bin/antlr: interpreter directive changed from "/bin/sh" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/sh"
/nix/store/ccdzqjfb2x03gk6vq78y457s9cpps9cm-antlr-2.7.7/bin/antlr-config: interpreter directive changed from "/bin/sh" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/sh"
/nix/store/ccdzqjfb2x03gk6vq78y457s9cpps9cm-antlr-2.7.7/sbin/pyantlr.sh: interpreter directive changed from "/usr/bin/env python" to "/nix/store/7sbvn0wgv7hsnxpss1jba723kx5nz6d4-python-2.7.15/bin/python"
checking for references to /build in /nix/store/ccdzqjfb2x03gk6vq78y457s9cpps9cm-antlr-2.7.7...
moving /nix/store/ccdzqjfb2x03gk6vq78y457s9cpps9cm-antlr-2.7.7/sbin/* to /nix/store/ccdzqjfb2x03gk6vq78y457s9cpps9cm-antlr-2.7.7/bin

@infinisil
Copy link
Member

Seems to work fine with python3 too

@FRidh FRidh merged commit 5785228 into NixOS:master Aug 3, 2018
@dotlambda dotlambda deleted the antlr-python2 branch March 21, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @GrahamcOfBorg @infinisil @FRidh