Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdf-redact-tools: explicitly use python2Packages #44400

Merged
merged 1 commit into from Aug 3, 2018
Merged

pdf-redact-tools: explicitly use python2Packages #44400

merged 1 commit into from Aug 3, 2018

Conversation

dotlambda
Copy link
Member

Python2-only syntax, e.g. print without paratheses, is used in the pdf-redact-tools script.

Motivation for this change

#18185

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @leenaars

pdf-redact-tools: explicitly use python2Packages
bf25656 
Python2-only syntax, e.g. print without paratheses, is used in the pdf-redact-tools script.
@dotlambda dotlambda changed the title pdfredacttools: explicitly use python2Packages pdf-redact-tools: explicitly use python2Packages Aug 3, 2018
@dotlambda dotlambda mentioned this pull request Aug 3, 2018
Closed
3 tasks
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pdf-redact-tools

Partial log (click to expand)

copying path '/nix/store/1c18p0vcvl9a1y9n5h9z7l5z1ssrs9d1-openexr-2.2.1-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/w818mpcfaq8w925q44f6wqmvah77gnw5-openexr-2.2.1-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/wnhfavfz94s8y4lzm7z56a495j25viwz-libxml2-2.9.8-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/6apqynl28hssyn2mscinzg0j65p9ij2q-libheif-1.3.2' from 'https://cache.nixos.org'...
copying path '/nix/store/n9q8m1vprh3f7pscv2w337lws8rhg2h1-imagemagick-6.9.9-34' from 'https://cache.nixos.org'...
copying path '/nix/store/dsjp7d2iyjxyh52bdg8ffh3m7hm7h1yl-openjpeg-2.3.0-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/icr3gyw8n7v18nz26d2vd7gqbpyd1ni0-ghostscript-9.22' from 'https://cache.nixos.org'...
copying path '/nix/store/w446iil53f2kxb11c8s50yd6zqkkh4nq-imagemagick-6.9.9-34-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/3d6kka2zwnpdwhng07xz5d3pjj5wan3l-pdf-redact-tools-0.1.2' from 'https://cache.nixos.org'...
/nix/store/3d6kka2zwnpdwhng07xz5d3pjj5wan3l-pdf-redact-tools-0.1.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pdf-redact-tools

Partial log (click to expand)

  /nix/store/kzvi64f41zi39w4mcx7jxyz1m16wmbl1-libheif-1.3.2
  /nix/store/md3h8r4d624v5cpqjxgmr91sr7yc7amm-imagemagick-6.9.9-34-dev
  /nix/store/p376i1hf34c1ik55mcncbzcczbwmnbva-libXt-1.1.5-dev
copying path '/nix/store/9lzrvlfgcyiw2khh2192wa9xbkrxfnq4-imagemagick-6.9.9-34-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/p376i1hf34c1ik55mcncbzcczbwmnbva-libXt-1.1.5-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/kzvi64f41zi39w4mcx7jxyz1m16wmbl1-libheif-1.3.2' from 'https://cache.nixos.org'...
copying path '/nix/store/6fqba7gbkscrk0p14zimyqnza7mj54gm-perl-Image-ExifTool-11.01' from 'https://cache.nixos.org'...
copying path '/nix/store/md3h8r4d624v5cpqjxgmr91sr7yc7amm-imagemagick-6.9.9-34-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/ixkh428ndimzdsm71ldva7dwf8nq2wx3-pdf-redact-tools-0.1.2' from 'https://cache.nixos.org'...
/nix/store/ixkh428ndimzdsm71ldva7dwf8nq2wx3-pdf-redact-tools-0.1.2

@Mic92 Mic92 merged commit de68304 into NixOS:master Aug 3, 2018
@dotlambda dotlambda deleted the pdfredacttools-python2 branch March 21, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @GrahamcOfBorg @Mic92