Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.Keras: 2.2.0 -> 2.2.2 #44390

Merged
merged 3 commits into from Aug 3, 2018
Merged

python.pkgs.Keras: 2.2.0 -> 2.2.2 #44390

merged 3 commits into from Aug 3, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

fixes #44274

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @NikolaMandic @twhitehead

@dotlambda dotlambda requested a review from FRidh as a code owner August 3, 2018 09:48
@infinisil
Copy link
Member

@GrahamcOfBorg build pythonPackages.Keras

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.Keras

Partial log (click to expand)

Requirement already satisfied: h5py in /nix/store/xzbp4k023994mxmn6h1xf1kxksh6axai-python2.7-h5py-2.8.0/lib/python2.7/site-packages (from Keras==2.2.2) (2.8.0)
Installing collected packages: Keras
Successfully installed Keras-2.2.2
/build/Keras-2.2.2
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jvcqx2qnaysq97fp0kmbx01wyw2wzl18-python2.7-Keras-2.2.2
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jvcqx2qnaysq97fp0kmbx01wyw2wzl18-python2.7-Keras-2.2.2/lib
patching script interpreter paths in /nix/store/jvcqx2qnaysq97fp0kmbx01wyw2wzl18-python2.7-Keras-2.2.2
checking for references to /build in /nix/store/jvcqx2qnaysq97fp0kmbx01wyw2wzl18-python2.7-Keras-2.2.2...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.Keras

Partial log (click to expand)

Installing collected packages: Keras
Successfully installed Keras-2.2.2
/build/Keras-2.2.2
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sbxalyifg3401bfjgvi6bfk7lb8bppc8-python2.7-Keras-2.2.2
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sbxalyifg3401bfjgvi6bfk7lb8bppc8-python2.7-Keras-2.2.2/lib
patching script interpreter paths in /nix/store/sbxalyifg3401bfjgvi6bfk7lb8bppc8-python2.7-Keras-2.2.2
checking for references to /build in /nix/store/sbxalyifg3401bfjgvi6bfk7lb8bppc8-python2.7-Keras-2.2.2...
/nix/store/sbxalyifg3401bfjgvi6bfk7lb8bppc8-python2.7-Keras-2.2.2

@dotlambda
Copy link
Member Author

Changed the commit message to reflect the actual package name (capitalized).

@dotlambda dotlambda changed the title python.pkgs.keras: 2.2.0 -> 2.2.2 python.pkgs.Keras: 2.2.0 -> 2.2.2 Aug 3, 2018
infinisil
infinisil approved these changes Aug 3, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge soon if nobody else complains

@FRidh FRidh merged commit e271c47 into NixOS:master Aug 3, 2018
@dotlambda dotlambda deleted the keras-2.2.2 branch March 21, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keras broken with commit aaf4d12
4 participants
@dotlambda @infinisil @GrahamcOfBorg @FRidh