-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
almonds: use python3 #44411
almonds: use python3 #44411
Conversation
@@ -20461,7 +20461,7 @@ with pkgs; | |||
|
|||
### SCIENCE/MATH | |||
|
|||
almonds = pythonPackages.callPackage ../applications/science/math/almonds { }; | |||
almonds = callPackage ../applications/science/math/almonds { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use python3Packages.callPackage
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using that is discouraged because that way, you lose the ability to override the python package set. Overriding a single dependency is not always what you want because you cannot use multiple versions of the same python package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the same applies to the pkgs
package set. Using .override
on a derivation only overrides the immediate deps, not the whole set. If anybody wanted to override the whole set, they can use overlays.
Edit: Oh well it doesn't matter much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But for Python applications, it's common to require a specific version of a dependency. This can be done by overriding pythonPackages
inside the application's expression.
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: almonds Partial log (click to expand)
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: almonds Partial log (click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me then, I have tested this, works fine
Motivation for this change
#18185
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)cc @infinisil