Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svtplay-dl: use python3Packages #44401

Closed
wants to merge 1 commit into from
Closed

svtplay-dl: use python3Packages #44401

wants to merge 1 commit into from

Conversation

dotlambda
Copy link
Member

Motivation for this change

#18185

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @rycee
Note that this is untested.

Btw, version 2.0 is available.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: svtplay-dl

Partial log (click to expand)

install -m 755 svtplay-dl /nix/store/h5x263crfq3h8c73q74fjhfvpbsk3pms-svtplay-dl-1.9.11/bin
install -m 644 svtplay-dl.1 /nix/store/h5x263crfq3h8c73q74fjhfvpbsk3pms-svtplay-dl-1.9.11/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h5x263crfq3h8c73q74fjhfvpbsk3pms-svtplay-dl-1.9.11
gzipping man pages under /nix/store/h5x263crfq3h8c73q74fjhfvpbsk3pms-svtplay-dl-1.9.11/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h5x263crfq3h8c73q74fjhfvpbsk3pms-svtplay-dl-1.9.11/bin
patching script interpreter paths in /nix/store/h5x263crfq3h8c73q74fjhfvpbsk3pms-svtplay-dl-1.9.11
checking for references to /build in /nix/store/h5x263crfq3h8c73q74fjhfvpbsk3pms-svtplay-dl-1.9.11...
/nix/store/h5x263crfq3h8c73q74fjhfvpbsk3pms-svtplay-dl-1.9.11

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: svtplay-dl

Partial log (click to expand)

install -m 755 svtplay-dl /nix/store/lwa676ddmfgdw1280m8rcnwffh33yimg-svtplay-dl-1.9.11/bin
install -m 644 svtplay-dl.1 /nix/store/lwa676ddmfgdw1280m8rcnwffh33yimg-svtplay-dl-1.9.11/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lwa676ddmfgdw1280m8rcnwffh33yimg-svtplay-dl-1.9.11
gzipping man pages under /nix/store/lwa676ddmfgdw1280m8rcnwffh33yimg-svtplay-dl-1.9.11/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lwa676ddmfgdw1280m8rcnwffh33yimg-svtplay-dl-1.9.11/bin
patching script interpreter paths in /nix/store/lwa676ddmfgdw1280m8rcnwffh33yimg-svtplay-dl-1.9.11
checking for references to /build in /nix/store/lwa676ddmfgdw1280m8rcnwffh33yimg-svtplay-dl-1.9.11...
/nix/store/lwa676ddmfgdw1280m8rcnwffh33yimg-svtplay-dl-1.9.11

@rycee
Copy link
Member

rycee commented Aug 5, 2018

Tested a bit and it works well. I've rebased this to master in ad377b4. Thanks!

I've been looking at updating to 2.0 but this version changes things quite a lot so the packaging needs to be changed. I also had some issues with test failures. I'll revisit this when I have time.

@rycee rycee closed this Aug 5, 2018
@dotlambda dotlambda deleted the svtplay-dl-python3 branch January 17, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @GrahamcOfBorg @rycee