bazaar: add patch file to the repo #44396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
External url with pach became unavailable. This is a manual cherry-pick from master
copumpkin
reviewed
Aug 3, 2018
| @@ -21,11 +20,7 @@ python2Packages.buildPythonApplication rec { | |||
| patches = [ | |||
| # Bazaar can't find the certificates alone | |||
| ./add_certificates.patch | |||
| (fetchpatch { | |||
| url = "https://bazaar.launchpad.net/~brz/brz/trunk/revision/6754"; | |||
There was a problem hiding this comment.
It looks like the .patch file is now at https://bazaar.launchpad.net/~brz/brz/trunk/diff/6754?context=3 instead. Can we just fetchpatch that URL instead of embedding the patch in the repo?
There was a problem hiding this comment.
Ah, it looks like @Izorkin did that in master. I guess we can just carry it over then, but in general I'd treat embedding literal patches in the repo as a last resort
There was a problem hiding this comment.
Another thought: if this could stay a FO derivation as fetchpatch, it wouldn't cause a giant rebuild 😄
|
Resolved in dd8ba51 |
|
I screwed it up, fixed now in release-18.03: 8de1206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
External url with pach became unavailable.
This is a manual cherry-pick from master