Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bluez: use python3 #44398

Merged
merged 2 commits into from Aug 5, 2018
Merged

bluez: use python3 #44398

merged 2 commits into from Aug 5, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

#18185

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @abbradar

Note that this was not tested.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: blueman

Partial log (click to expand)

wrapping `/nix/store/vq06c17a74mifizah860cawnzhsp0ccs-blueman-2.0.5/bin/.blueman-applet-wrapped'...
wrapping `/nix/store/vq06c17a74mifizah860cawnzhsp0ccs-blueman-2.0.5/bin/.blueman-assistant-wrapped'...
wrapping `/nix/store/vq06c17a74mifizah860cawnzhsp0ccs-blueman-2.0.5/bin/.blueman-browse-wrapped'...
wrapping `/nix/store/vq06c17a74mifizah860cawnzhsp0ccs-blueman-2.0.5/bin/.blueman-report-wrapped'...
wrapping `/nix/store/vq06c17a74mifizah860cawnzhsp0ccs-blueman-2.0.5/bin/.blueman-sendto-wrapped'...
wrapping `/nix/store/vq06c17a74mifizah860cawnzhsp0ccs-blueman-2.0.5/bin/.blueman-adapters-wrapped'...
wrapping `/nix/store/vq06c17a74mifizah860cawnzhsp0ccs-blueman-2.0.5/bin/.blueman-manager-wrapped'...
wrapping `/nix/store/vq06c17a74mifizah860cawnzhsp0ccs-blueman-2.0.5/bin/.blueman-services-wrapped'...
wrapping `/nix/store/vq06c17a74mifizah860cawnzhsp0ccs-blueman-2.0.5/libexec/.blueman-mechanism-wrapped'...
wrapping `/nix/store/vq06c17a74mifizah860cawnzhsp0ccs-blueman-2.0.5/libexec/.blueman-rfcomm-watcher-wrapped'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: blueman

Partial log (click to expand)

wrapping `/nix/store/zxi0b38vz6pcavmzxaln35qw8f6l105l-blueman-2.0.5/bin/.blueman-browse-wrapped'...
wrapping `/nix/store/zxi0b38vz6pcavmzxaln35qw8f6l105l-blueman-2.0.5/bin/.blueman-assistant-wrapped'...
wrapping `/nix/store/zxi0b38vz6pcavmzxaln35qw8f6l105l-blueman-2.0.5/bin/.blueman-sendto-wrapped'...
wrapping `/nix/store/zxi0b38vz6pcavmzxaln35qw8f6l105l-blueman-2.0.5/bin/.blueman-services-wrapped'...
wrapping `/nix/store/zxi0b38vz6pcavmzxaln35qw8f6l105l-blueman-2.0.5/bin/.blueman-manager-wrapped'...
wrapping `/nix/store/zxi0b38vz6pcavmzxaln35qw8f6l105l-blueman-2.0.5/bin/.blueman-applet-wrapped'...
wrapping `/nix/store/zxi0b38vz6pcavmzxaln35qw8f6l105l-blueman-2.0.5/bin/.blueman-adapters-wrapped'...
wrapping `/nix/store/zxi0b38vz6pcavmzxaln35qw8f6l105l-blueman-2.0.5/libexec/.blueman-mechanism-wrapped'...
wrapping `/nix/store/zxi0b38vz6pcavmzxaln35qw8f6l105l-blueman-2.0.5/libexec/.blueman-rfcomm-watcher-wrapped'...
/nix/store/zxi0b38vz6pcavmzxaln35qw8f6l105l-blueman-2.0.5

@infinisil
Copy link
Member

Python 2 still gets pulled in because of the bluez dependency. Can you make bluez use Python 3 as well?

@dotlambda dotlambda mentioned this pull request Aug 5, 2018
Merged
9 tasks
@infinisil
Copy link
Member

Tested it quickly, works without problems

@dotlambda dotlambda changed the title blueman: use python3Packages bluez: use python3 Aug 5, 2018
@infinisil infinisil merged commit 56ac23a into NixOS:master Aug 5, 2018
@dotlambda
Copy link
Member Author

I'm not sure whether this should have been merged into master.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: blueman, bluez

Partial log (click to expand)

cannot build derivation '/nix/store/y4c8f0hmf3dn42ch28avw9ivsfyrfrz6-bluez-5.50.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/7452ni8m8kzi698sq8xx5176rn7yx30g-gtk+3-3.22.30.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/d77gqy360z5j0l84laaa3b483cwdvyj2-libgsf-1.14.42.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/f12pzxr8q93rz2qlxqnvh2h9zzqjwkcz-libnotify-0.7.7.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/h0825d7cbhyl5545zfb32p6xmqqvgcds-librsvg-2.42.4.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/x217rjniw7bf63dai77qkb67nh4djh64-openobex-1.7.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0amzrqm02navy6lwflw74hfg28gs1fy3-hook.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/62cawnsaqp9rs6hkyxd56cn0xly3m7gr-obex-data-server-0.4.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/pp1vywkyiwsz0hjw77b323qw08lhyhp7-blueman-2.0.5.drv': 10 dependencies couldn't be built
error: build of '/nix/store/pp1vywkyiwsz0hjw77b323qw08lhyhp7-blueman-2.0.5.drv', '/nix/store/y4c8f0hmf3dn42ch28avw9ivsfyrfrz6-bluez-5.50.drv' failed

@infinisil
Copy link
Member

@dotlambda I think just a big number of rebuilds doesn't automatically mean staging, staging is mainly thought for stdenv big things afaik. So I think this is okay.

Also, the above failure seems to be from Rust not building again, not related to this PR (I didn't notice because I didn't test off the merge, ofborg does).

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: blueman, bluez

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/81yv134wfram6hy6li2sxkiymmgbld2p-obex-data-server-0.4.6
shrinking /nix/store/81yv134wfram6hy6li2sxkiymmgbld2p-obex-data-server-0.4.6/bin/obex-data-server
gzipping man pages under /nix/store/81yv134wfram6hy6li2sxkiymmgbld2p-obex-data-server-0.4.6/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/81yv134wfram6hy6li2sxkiymmgbld2p-obex-data-server-0.4.6/bin
patching script interpreter paths in /nix/store/81yv134wfram6hy6li2sxkiymmgbld2p-obex-data-server-0.4.6
checking for references to /build in /nix/store/81yv134wfram6hy6li2sxkiymmgbld2p-obex-data-server-0.4.6...
cannot build derivation '/nix/store/mh368r5cwxcxb1jklzmcwfqn9xlzv06g-blueman-2.0.5.drv': 2 dependencies couldn't be built
error: build of '/nix/store/mh368r5cwxcxb1jklzmcwfqn9xlzv06g-blueman-2.0.5.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @GrahamcOfBorg @infinisil @rnhmjoj