certmgr: init at 1.6.1 #44406
Merged
certmgr: init at 1.6.1 #44406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
reviewed
Aug 3, 2018
|
|
||
| goPackagePath = "github.com/cloudflare/certmgr/"; | ||
|
|
||
| nativeBuildInputs = [ ]; |
There was a problem hiding this comment.
Of course. Though I already did that. Apparently not.. Removed now :)
johanot
force-pushed
the
certmgr-pkgs-init
branch
from
9504238
to
813f64b
Compare
infinisil
reviewed
Aug 3, 2018
pkgs/top-level/all-packages.nix
Outdated
| @@ -117,6 +117,8 @@ with pkgs; | |||
|
|
|||
| cmark = callPackage ../development/libraries/cmark { }; | |||
|
|
|||
| certmgr = callPackage ../tools/security/certmgr { }; | |||
There was a problem hiding this comment.
Can you move this to a more relevant section into all-packages.nix? Maybe line 1700. (Not blaming you though, that file is a mess..)
There was a problem hiding this comment.
Thanks. Done now. Yeah, would have been slightly better if it was just a single big sorted list.
johanot
force-pushed
the
certmgr-pkgs-init
branch
from
813f64b
to
5050074
Compare
infinisil
approved these changes
Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Certmgr is a Cloudflare client intended for interacting with cfssl.
Based on declarative specification, it can request new, and monitor existing, x509 certificates on any host and renew them automatically when required.
Certmgr can be used interactively on the cmdline to query and manage certficates, or it can be run as a daemon that continuously watches selected certificates. I will follow up soon with a nixos module for configuring the certmgr-daemon in particular.
As agreed with @srhb, I've added both of us as package maintainers.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)