Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMA: use python3 #44407

Merged
merged 1 commit into from Aug 9, 2018
Merged

MMA: use python3 #44407

merged 1 commit into from Aug 9, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

#18185

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @magnetophon
Note that this was not tested.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: MMA

Partial log (click to expand)

     Files processed: 225
     Total number of grooves: 1622

shrinking RPATHs of ELF executables and libraries in /nix/store/9a6s54vyn2q0kqda8cziwr6riqli9i1i-mma-16.06
gzipping man pages under /nix/store/9a6s54vyn2q0kqda8cziwr6riqli9i1i-mma-16.06/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9a6s54vyn2q0kqda8cziwr6riqli9i1i-mma-16.06/bin
patching script interpreter paths in /nix/store/9a6s54vyn2q0kqda8cziwr6riqli9i1i-mma-16.06
checking for references to /build in /nix/store/9a6s54vyn2q0kqda8cziwr6riqli9i1i-mma-16.06...
/nix/store/9a6s54vyn2q0kqda8cziwr6riqli9i1i-mma-16.06

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: MMA

Partial log (click to expand)

     Files processed: 225
     Total number of grooves: 1622

shrinking RPATHs of ELF executables and libraries in /nix/store/m96bfmnz7dm1v0z07yk3wq5z9lsr5kzn-mma-16.06
gzipping man pages under /nix/store/m96bfmnz7dm1v0z07yk3wq5z9lsr5kzn-mma-16.06/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m96bfmnz7dm1v0z07yk3wq5z9lsr5kzn-mma-16.06/bin
patching script interpreter paths in /nix/store/m96bfmnz7dm1v0z07yk3wq5z9lsr5kzn-mma-16.06
checking for references to /build in /nix/store/m96bfmnz7dm1v0z07yk3wq5z9lsr5kzn-mma-16.06...
/nix/store/m96bfmnz7dm1v0z07yk3wq5z9lsr5kzn-mma-16.06

FRidh
FRidh requested changes Aug 3, 2018
View reviewed changes
pkgs/applications/audio/MMA/default.nix Outdated
@@ -18,7 +18,7 @@
sed -i 's@/usr/bin/arecord@/${alsaUtils}/bin/arecord@g' util/mma-splitrec.py
sed -i 's@/usr/bin/timidity@/${timidity}/bin/timidity@g' mma-splitrec
sed -i 's@/usr/bin/timidity@/${timidity}/bin/timidity@g' util/mma-splitrec.py
find . -type f | xargs sed -i 's@/usr/bin/env python@${python}/bin/python@g'
find . -type f | xargs sed -i 's@/usr/bin/env python@${python3}/bin/python@g'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${python3.interpreter}

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: MMA

Partial log (click to expand)

     Files processed: 225
     Total number of grooves: 1622

shrinking RPATHs of ELF executables and libraries in /nix/store/3hfld4s3jdpw3xk0iprzqhl19bpy2b0g-mma-16.06
gzipping man pages under /nix/store/3hfld4s3jdpw3xk0iprzqhl19bpy2b0g-mma-16.06/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3hfld4s3jdpw3xk0iprzqhl19bpy2b0g-mma-16.06/bin
patching script interpreter paths in /nix/store/3hfld4s3jdpw3xk0iprzqhl19bpy2b0g-mma-16.06
checking for references to /build in /nix/store/3hfld4s3jdpw3xk0iprzqhl19bpy2b0g-mma-16.06...
/nix/store/3hfld4s3jdpw3xk0iprzqhl19bpy2b0g-mma-16.06

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: MMA

Partial log (click to expand)

     Files processed: 225
     Total number of grooves: 1622

shrinking RPATHs of ELF executables and libraries in /nix/store/6hb2wd61xy70f8pwbkm2687xn46gpi0l-mma-16.06
gzipping man pages under /nix/store/6hb2wd61xy70f8pwbkm2687xn46gpi0l-mma-16.06/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6hb2wd61xy70f8pwbkm2687xn46gpi0l-mma-16.06/bin
patching script interpreter paths in /nix/store/6hb2wd61xy70f8pwbkm2687xn46gpi0l-mma-16.06
checking for references to /build in /nix/store/6hb2wd61xy70f8pwbkm2687xn46gpi0l-mma-16.06...
/nix/store/6hb2wd61xy70f8pwbkm2687xn46gpi0l-mma-16.06

xeji
xeji approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback was addressed. LGTM.

@xeji xeji merged commit 3dbdc64 into NixOS:master Aug 9, 2018
@dotlambda dotlambda deleted the MMA-python3 branch January 17, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @GrahamcOfBorg @FRidh @xeji