-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MMA: use python3 #44407
MMA: use python3 #44407
Conversation
Success on x86_64-linux (full log) Attempted: MMA Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: MMA Partial log (click to expand)
|
@@ -18,7 +18,7 @@ | |||
sed -i 's@/usr/bin/arecord@/${alsaUtils}/bin/arecord@g' util/mma-splitrec.py | |||
sed -i 's@/usr/bin/timidity@/${timidity}/bin/timidity@g' mma-splitrec | |||
sed -i 's@/usr/bin/timidity@/${timidity}/bin/timidity@g' util/mma-splitrec.py | |||
find . -type f | xargs sed -i 's@/usr/bin/env python@${python}/bin/python@g' | |||
find . -type f | xargs sed -i 's@/usr/bin/env python@${python3}/bin/python@g' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
${python3.interpreter}
Success on aarch64-linux (full log) Attempted: MMA Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: MMA Partial log (click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback was addressed. LGTM.
Motivation for this change
#18185
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)cc @magnetophon
Note that this was not tested.