Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reaper: init at 5.93 #44391

Merged
merged 1 commit into from Aug 3, 2018
Merged

reaper: init at 5.93 #44391

merged 1 commit into from Aug 3, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

Linux native builds of REAPER are now available.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

The UI is hideous. I've got to see if this is the case on other Linux distributions as well.

@xeji
Copy link
Contributor

xeji commented Aug 3, 2018

yep, the UI looks like from the 1990s, in particular the fonts. Incorrect/missing font path, maybe?

@xeji
Copy link
Contributor

xeji commented Aug 3, 2018

eval error was unrelated, fixed
@GrahamcOfBorg eval

@xeji
Copy link
Contributor

xeji commented Aug 3, 2018

Anyway, it builds and runs, so I'll merge it now and you can improve the looks later.

@xeji xeji merged commit d99d14f into NixOS:master Aug 3, 2018
@jfrankenau jfrankenau deleted the init-reaper branch August 3, 2018 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants