Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundler: 1.16.2 -> 1.16.3 #44404

Merged
merged 1 commit into from Aug 3, 2018
Merged

bundler: 1.16.2 -> 1.16.3 #44404

merged 1 commit into from Aug 3, 2018

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Aug 3, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@alyssais alyssais requested a review from zimbatm as a code owner August 3, 2018 15:01
@xeji
Copy link
Contributor

xeji commented Aug 3, 2018

@GrahamcOfBorg build bundler

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bundler

Partial log (click to expand)

WARNING:  You build with buildroot.
  Build root: /
  Bin dir: /nix/store/i18wjrwmc2b52541p10q7a3hk213ihwa-bundler-1.16.3/lib/ruby/gems/2.4.0/bin
  Gem home: /nix/store/i18wjrwmc2b52541p10q7a3hk213ihwa-bundler-1.16.3/lib/ruby/gems/2.4.0
Successfully installed bundler-1.16.3
1 gem installed
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i18wjrwmc2b52541p10q7a3hk213ihwa-bundler-1.16.3
checking for references to /build in /nix/store/i18wjrwmc2b52541p10q7a3hk213ihwa-bundler-1.16.3...
/nix/store/i18wjrwmc2b52541p10q7a3hk213ihwa-bundler-1.16.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bundler

Partial log (click to expand)

WARNING:  You build with buildroot.
  Build root: /
  Bin dir: /nix/store/bff52xb0yd64yg57jcid7n6r953xrs21-bundler-1.16.3/lib/ruby/gems/2.4.0/bin
  Gem home: /nix/store/bff52xb0yd64yg57jcid7n6r953xrs21-bundler-1.16.3/lib/ruby/gems/2.4.0
Successfully installed bundler-1.16.3
1 gem installed
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bff52xb0yd64yg57jcid7n6r953xrs21-bundler-1.16.3
checking for references to /build in /nix/store/bff52xb0yd64yg57jcid7n6r953xrs21-bundler-1.16.3...
/nix/store/bff52xb0yd64yg57jcid7n6r953xrs21-bundler-1.16.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: bundler

Partial log (click to expand)

installing
buildFlags:
WARNING:  You build with buildroot.
  Build root: /
  Bin dir: /nix/store/kic69908x05bd0rjamyq9q8xmdbc984f-bundler-1.16.3/lib/ruby/gems/2.4.0/bin
  Gem home: /nix/store/kic69908x05bd0rjamyq9q8xmdbc984f-bundler-1.16.3/lib/ruby/gems/2.4.0
Successfully installed bundler-1.16.3
1 gem installed
post-installation fixup
/nix/store/kic69908x05bd0rjamyq9q8xmdbc984f-bundler-1.16.3

@xeji
Copy link
Contributor

xeji commented Aug 3, 2018

Changelog: https://github.com/bundler/bundler/blob/master/CHANGELOG.md

@infinisil
Copy link
Member

@GrahamcOfBorg build weechat travis sass gitaly bundix vulnix fastlane

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: weechat, travis, sass, gitaly, bundix, vulnix, fastlane

Partial log (click to expand)

Coverage HTML written to dir htmlcov

========================= 60 passed in 160.05 seconds ==========================
/nix/store/fp04i2cdvvxinx0zxz1ikdrhqlqhhhkz-weechat
/nix/store/iis2pb57ir2cfbpi05cm8zwwm1hxk5kw-travis-1.8.8
/nix/store/79xabxi254bahbz2j9hn6pbm4kkzm1zl-sass-3.5.6
/nix/store/ajjzrhmbsplhxknw1s9ppm70rxv568pf-gitaly-0.100.0-bin
/nix/store/1bbxg3zc9g92b62zh54yga7ha1rl7lnb-bundix-2.3.1
/nix/store/sxrgm28igqm1mnkh3misa30422w1wrax-vulnix-1.7.1
/nix/store/yl950yf90wmqg1zakhcd6x63yq7a99m7-fastlane-2.91.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: weechat, travis, sass, gitaly, bundix, vulnix, fastlane

Partial log (click to expand)

/nix/store/jq176h4ina3lp5kh6sbq0vac0xnc726w-gitaly-0.100.0-ruby/vendor/gitlab_git/lib/gitlab/git/support/format-git-cat-file-input: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/f32srrdsi3fd31m1rp0d7gx5sa7b6x70-wrapped-ruby-gitaly-env/bin/ruby"
checking for references to /tmp/nix-build-gitaly-0.100.0.drv-0 in /nix/store/jq176h4ina3lp5kh6sbq0vac0xnc726w-gitaly-0.100.0-ruby...
building path(s) ‘/nix/store/5nr8gbf90ncg8vqkmkh4gbfa8awyrrzl-weechat’
/nix/store/5nr8gbf90ncg8vqkmkh4gbfa8awyrrzl-weechat
/nix/store/qcslx4zivsnjdy8axylp27j6n8ky3r8w-travis-1.8.8
/nix/store/35mfrwna1mqid7r23i7xqynn4njv68sw-sass-3.5.6
/nix/store/21nk0ib93wywxn6pgh0lmqg717jaa629-gitaly-0.100.0-bin
/nix/store/9gim22h0r4w3hhm7b54l3zv0iyydf1ps-bundix-2.3.1
/nix/store/bhh1sy7cqw94smpbgwga2m84ad60cmpd-vulnix-1.7.1
/nix/store/azkbn9njj0wnc8z3zsaa6iybnim1dmhw-fastlane-2.91.0

infinisil
infinisil approved these changes Aug 3, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@infinisil infinisil merged commit ce4e1a1 into NixOS:master Aug 3, 2018
@alyssais alyssais deleted the bundler branch August 13, 2018 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@xeji xeji xeji approved these changes

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alyssais @xeji @GrahamcOfBorg @infinisil