Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamspeak_server: 3.0.13.6 -> 3.3.0 #45161

Merged
merged 1 commit into from Sep 23, 2018
Merged

teamspeak_server: 3.0.13.6 -> 3.3.0 #45161

merged 1 commit into from Sep 23, 2018

Conversation

Gerschtli
Copy link
Contributor

@Gerschtli Gerschtli commented Aug 16, 2018 •
edited

Motivation for this change

Updates teamspeak server to 3.3.0.

To fix following error, I introduced a new parameter in the systemd config ExecStart.

Please set the environment variable TS3SERVER_LICENSE to "accept" in order to accept the license agreement.
Alternatively, create a file named ".ts3server_license_accepted" in the working directory or start the server with the command line parameter "license_accepted=1".
To view the license agreement set TS3SERVER_LICENSE to "view" in order to print the license to the console.
Alternatively view the file "LICENSE" in your favorite text viewer yourself.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Aug 25, 2018

While this is obviously a very annoying change, I feel that there's something fishy about users suddenly accepting a license they didn't explicitly accept before, just because this is enabled. Maybe it should be guarded by an option?

@Gerschtli
Copy link
Contributor Author

Gerschtli commented Aug 25, 2018 •
edited

That would mean you need to set enable and acceptLicense separatly to enable this module. I'm not sure how this case is handled in nixpkgs before..
For other unfree software I think the license gets accepted implicitly.

@srhb
Copy link
Contributor

srhb commented Aug 25, 2018

Yeah, I see your point. Not sure what's best, will try to solicit some more input.

@Gerschtli
Copy link
Contributor Author

Whats the status of this PR?

@srhb
Copy link
Contributor

srhb commented Sep 23, 2018

I have been unable to get anyone else to have an opinion on the subject, so I guess we'll go with mine:

Since we assume the license has been accepted for every single other enabled option usually, it should be no different in this case.

@srhb srhb merged commit 7fb0194 into NixOS:master Sep 23, 2018
@Gerschtli Gerschtli deleted the update/ts3 branch September 23, 2018 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gerschtli @srhb @GrahamcOfBorg