Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.gdm: 2.28.2 -> 2.28.3 #45207

Merged
merged 1 commit into from Aug 17, 2018
Merged

gnome3.gdm: 2.28.2 -> 2.28.3 #45207

merged 1 commit into from Aug 17, 2018

Conversation

andir
Copy link
Member

@andir andir commented Aug 17, 2018

Motivation for this change

Changes:

  • CVE-2018-14424 - double free fix
  • lifecycle fixes to libgdm/GdmClient
  • follow up fixes dealing with login screen reaping form last release
  • allow pam modules to use SIGUSR1
  • set PWD for user session
  • tell cirrus not to use wayland
  • Translation updates
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@andir
gnome3.gdm: 2.28.2 -> 2.28.3
a4ded94 
Changes:
  - CVE-2018-14424 - double free fix
  - lifecycle fixes to libgdm/GdmClient
  - follow up fixes dealing with login screen reaping form last release
  - allow pam modules to use SIGUSR1
  - set PWD for user session
  - tell cirrus not to use wayland
  - Translation updates
@andir andir requested a review from jtojnar August 17, 2018 07:31
@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 labels Aug 17, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gnome3.gdm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gnome3.gdm

Partial log (click to expand)

strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xjqmdrvdh0qf6213ar3xl00wynbrad3j-gdm-3.28.3/lib  /nix/store/xjqmdrvdh0qf6213ar3xl00wynbrad3j-gdm-3.28.3/libexec  /nix/store/xjqmdrvdh0qf6213ar3xl00wynbrad3j-gdm-3.28.3/bin  /nix/store/xjqmdrvdh0qf6213ar3xl00wynbrad3j-gdm-3.28.3/sbin
patching script interpreter paths in /nix/store/xjqmdrvdh0qf6213ar3xl00wynbrad3j-gdm-3.28.3
/nix/store/xjqmdrvdh0qf6213ar3xl00wynbrad3j-gdm-3.28.3/etc/gdm/PreSession/Default: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/xjqmdrvdh0qf6213ar3xl00wynbrad3j-gdm-3.28.3/etc/gdm/Init/Default: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/xjqmdrvdh0qf6213ar3xl00wynbrad3j-gdm-3.28.3/etc/gdm/PostLogin/Default.sample: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/xjqmdrvdh0qf6213ar3xl00wynbrad3j-gdm-3.28.3/etc/gdm/PostSession/Default: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/xjqmdrvdh0qf6213ar3xl00wynbrad3j-gdm-3.28.3/etc/gdm/Xsession: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/xjqmdrvdh0qf6213ar3xl00wynbrad3j-gdm-3.28.3...
moving /nix/store/xjqmdrvdh0qf6213ar3xl00wynbrad3j-gdm-3.28.3/sbin/* to /nix/store/xjqmdrvdh0qf6213ar3xl00wynbrad3j-gdm-3.28.3/bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gnome3.gdm

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/rlkymi5b6ivqs8q59xmbmc4rrjvs3v7w-gdm-3.28.3/lib  /nix/store/rlkymi5b6ivqs8q59xmbmc4rrjvs3v7w-gdm-3.28.3/libexec  /nix/store/rlkymi5b6ivqs8q59xmbmc4rrjvs3v7w-gdm-3.28.3/bin  /nix/store/rlkymi5b6ivqs8q59xmbmc4rrjvs3v7w-gdm-3.28.3/sbin
patching script interpreter paths in /nix/store/rlkymi5b6ivqs8q59xmbmc4rrjvs3v7w-gdm-3.28.3
/nix/store/rlkymi5b6ivqs8q59xmbmc4rrjvs3v7w-gdm-3.28.3/etc/gdm/PostSession/Default: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/rlkymi5b6ivqs8q59xmbmc4rrjvs3v7w-gdm-3.28.3/etc/gdm/PreSession/Default: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/rlkymi5b6ivqs8q59xmbmc4rrjvs3v7w-gdm-3.28.3/etc/gdm/PostLogin/Default.sample: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/rlkymi5b6ivqs8q59xmbmc4rrjvs3v7w-gdm-3.28.3/etc/gdm/Init/Default: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/rlkymi5b6ivqs8q59xmbmc4rrjvs3v7w-gdm-3.28.3/etc/gdm/Xsession: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/rlkymi5b6ivqs8q59xmbmc4rrjvs3v7w-gdm-3.28.3...
moving /nix/store/rlkymi5b6ivqs8q59xmbmc4rrjvs3v7w-gdm-3.28.3/sbin/* to /nix/store/rlkymi5b6ivqs8q59xmbmc4rrjvs3v7w-gdm-3.28.3/bin
/nix/store/rlkymi5b6ivqs8q59xmbmc4rrjvs3v7w-gdm-3.28.3

@jtojnar
Copy link
Contributor

jtojnar commented Aug 17, 2018

@GrahamcOfBorg test gnome3-gdm

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.gnome3-gdm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.gnome3-gdm

Partial log (click to expand)

machine: running command: sync
machine# [  283.639042] rtkit-daemon[1055]: Successfully made thread 1054 of process 1054 (/nix/store/vs5hzkqgcxwwy76rcc66027w9cln6a7w-pulseaudio-12.2/bin/pulseaudio) owned by 'alice' high priority at nice level -11.
machine# [  283.672359] rtkit-daemon[1055]: Supervising 1 threads of 1 processes of 1 users.
machine: exit status 0
test script finished in 288.03s
cleaning up
killing machine (pid 600)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/cmbvqam3gy16ffklr6hs7c8m403764wh-vm-test-run-gnome3-gdm

@andir andir merged commit 20aba7a into NixOS:master Aug 17, 2018
@andir andir deleted the gdm branch August 17, 2018 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
1.severity: security 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @GrahamcOfBorg @jtojnar