Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/doc: New installer note on unattended installs #45215

Merged
merged 1 commit into from Aug 21, 2018

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Aug 17, 2018

Motivation for this change

The installer no longer automatically switches off the prompt for the new root password based on mutableUsers, but instead takes a switch --no-root-passwd

Fixes #44906

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Copy link
Member

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the phrasing changes, but the only requested change is the typo.

Thanks for the doc update!

@@ -326,10 +326,11 @@ Retype new UNIX password: ***
</screen>
<note>
<para>
To prevent the password prompt, set
During unattanded installations, ie. with the option
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/unattanded/unattended/


"ie." would mean "During unattended installations, in other words with the option [mutableUsers = false][...]".

This may be fine, though "unattended installation" does not (forcibly) imply "mutableUsers = false".

What do you think of:

During unattended installations, where no root password is expected to be given interactively, it is possible to use [...]

This, though, loses the mutableUsers = false hint, but makes the statement more global; It is just as well possible to want a mutableUser = true installation be installed unattended, right?

Feel free to consider other alternatives, including and excluding the configuration hints.

@srhb
Copy link
Contributor Author

srhb commented Aug 19, 2018

@samueldr Thanks, good point. Done. :)

Copy link
Member

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samueldr samueldr merged commit 73d348c into NixOS:master Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants