New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/doc: New installer note on unattended installs #45215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider the phrasing changes, but the only requested change is the typo.
Thanks for the doc update!
@@ -326,10 +326,11 @@ Retype new UNIX password: *** | |||
</screen> | |||
<note> | |||
<para> | |||
To prevent the password prompt, set | |||
During unattanded installations, ie. with the option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/unattanded/unattended/
"ie." would mean "During unattended installations, in other words with the option [mutableUsers = false][...]".
This may be fine, though "unattended installation" does not (forcibly) imply "mutableUsers = false".
What do you think of:
During unattended installations, where no root password is expected to be given interactively, it is possible to use [...]
This, though, loses the mutableUsers = false
hint, but makes the statement more global; It is just as well possible to want a mutableUser = true
installation be installed unattended, right?
Feel free to consider other alternatives, including and excluding the configuration hints.
3f84cb9
to
9efa99e
Compare
9efa99e
to
05d85a2
Compare
@samueldr Thanks, good point. Done. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation for this change
The installer no longer automatically switches off the prompt for the new root password based on
mutableUsers
, but instead takes a switch--no-root-passwd
Fixes #44906
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)