mariadb: 10.2.16 -> 10.2.17 #45199

andir · 2018-08-17T06:44:53Z

Motivation for this change

mariadb: 10.2.16 -> 10.2.17

Bump to latest stable version of the 10.2.x branch. Besides many bug fixes the
following security related issues have been fixed:

Also includes a test for mariadb based on the existing mysql test.

This should be considered for backporting since the version in 18.03 has even more open issues...

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

andir · 2018-08-17T06:45:43Z

@GrahamcOfBorg test mysql

GrahamcOfBorg · 2018-08-17T06:45:57Z

Success on x86_64-linux

Attempted: tests.mysql

No partial log is available.

GrahamcOfBorg · 2018-08-17T06:46:30Z

Success on aarch64-linux

Attempted: tests.mysql

No partial log is available.

GrahamcOfBorg · 2018-08-17T07:11:37Z

Success on x86_64-linux (full log)

Attempted: mariadb

Partial log (click to expand)

/nix/store/b2swk93dczz4yi5dxr03r71vig4c90j4-mariadb-10.2.17/bin/galera_new_cluster: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/b2swk93dczz4yi5dxr03r71vig4c90j4-mariadb-10.2.17/bin/mariadb-service-convert: interpreter directive changed from "/bin/bash" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/bash"
/nix/store/b2swk93dczz4yi5dxr03r71vig4c90j4-mariadb-10.2.17/bin/wsrep_sst_mysqldump: interpreter directive changed from "/bin/bash -ue" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/bash -ue"
/nix/store/b2swk93dczz4yi5dxr03r71vig4c90j4-mariadb-10.2.17/bin/wsrep_sst_xtrabackup-v2: interpreter directive changed from "/bin/bash -ue" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/bash -ue"
/nix/store/b2swk93dczz4yi5dxr03r71vig4c90j4-mariadb-10.2.17/bin/mysql_secure_installation: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/b2swk93dczz4yi5dxr03r71vig4c90j4-mariadb-10.2.17/bin/msql2mysql: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/b2swk93dczz4yi5dxr03r71vig4c90j4-mariadb-10.2.17/bin/wsrep_sst_rsync: interpreter directive changed from "/bin/sh -ue" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh -ue"
/nix/store/b2swk93dczz4yi5dxr03r71vig4c90j4-mariadb-10.2.17/bin/wsrep_sst_mariabackup: interpreter directive changed from "/bin/bash -ue" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/bash -ue"
checking for references to /build in /nix/store/b2swk93dczz4yi5dxr03r71vig4c90j4-mariadb-10.2.17...
/nix/store/b2swk93dczz4yi5dxr03r71vig4c90j4-mariadb-10.2.17

GrahamcOfBorg · 2018-08-17T07:25:16Z

Success on aarch64-linux (full log)

Attempted: mariadb

Partial log (click to expand)

/nix/store/7yy2gaw4r74va2jq9k764xfb93k9vxc1-mariadb-10.2.17/bin/mysql_secure_installation: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/7yy2gaw4r74va2jq9k764xfb93k9vxc1-mariadb-10.2.17/bin/mysql_config: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/7yy2gaw4r74va2jq9k764xfb93k9vxc1-mariadb-10.2.17/bin/msql2mysql: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/7yy2gaw4r74va2jq9k764xfb93k9vxc1-mariadb-10.2.17/bin/mysql_install_db: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/7yy2gaw4r74va2jq9k764xfb93k9vxc1-mariadb-10.2.17/share/mysql/mysql.server: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/7yy2gaw4r74va2jq9k764xfb93k9vxc1-mariadb-10.2.17/share/mysql/wsrep_notify: interpreter directive changed from "/bin/sh -eu" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh -eu"
/nix/store/7yy2gaw4r74va2jq9k764xfb93k9vxc1-mariadb-10.2.17/share/mysql/binary-configure: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/7yy2gaw4r74va2jq9k764xfb93k9vxc1-mariadb-10.2.17/share/mysql/mysqld_multi.server: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/7yy2gaw4r74va2jq9k764xfb93k9vxc1-mariadb-10.2.17...
/nix/store/7yy2gaw4r74va2jq9k764xfb93k9vxc1-mariadb-10.2.17

GrahamcOfBorg · 2018-08-17T07:26:51Z

Success on x86_64-darwin (full log)

Attempted: mariadb

Partial log (click to expand)

/nix/store/bprmjz5liv21c04ki8fdas3q04a7njx6-mariadb-10.2.17/lib/libmysqld.19.dylib: fixing dylib
/nix/store/bprmjz5liv21c04ki8fdas3q04a7njx6-mariadb-10.2.17/lib/libmariadb.3.dylib: fixing dylib
/nix/store/bprmjz5liv21c04ki8fdas3q04a7njx6-mariadb-10.2.17/lib/libmysqld.19.dylib: fixing dylib
/nix/store/bprmjz5liv21c04ki8fdas3q04a7njx6-mariadb-10.2.17/lib/libmariadb.3.dylib: fixing dylib
/nix/store/bprmjz5liv21c04ki8fdas3q04a7njx6-mariadb-10.2.17/lib/libmysqld.19.dylib: fixing dylib
/nix/store/bprmjz5liv21c04ki8fdas3q04a7njx6-mariadb-10.2.17/lib/libmariadb.3.dylib: fixing dylib
/nix/store/bprmjz5liv21c04ki8fdas3q04a7njx6-mariadb-10.2.17/lib/libmysqld.19.dylib: fixing dylib
/nix/store/bprmjz5liv21c04ki8fdas3q04a7njx6-mariadb-10.2.17/lib/libmariadb.3.dylib: fixing dylib
/nix/store/bprmjz5liv21c04ki8fdas3q04a7njx6-mariadb-10.2.17/lib/libmysqld.19.dylib: fixing dylib
/nix/store/bprmjz5liv21c04ki8fdas3q04a7njx6-mariadb-10.2.17

vcunat · 2018-08-17T09:52:49Z

nixos/tests/mysql.nix

+        {
+          services.mysql.enable = true;
+          services.mysql.initialDatabases = [ { name = "testdb"; schema = ./testdb.sql; } ];
+          services.mysql.package = pkgs.mysql;


Are you sure this changes for the different tests?

Ups, I changed it :)

vcunat · 2018-08-17T09:52:56Z

Staged for 18.03 as 8a804f7.

The NixOS module already covers mariadb so the mysql test can easily be used as a vehicle for mariadb.

Bump to latest stable version of the 10.2.x branch. Besides many bug fixes the following security related issues have been fixed: - CVE-2018-3060 - CVE-2018-3064 - CVE-2018-3063 - CVE-2018-3058 - CVE-2018-3066 Release notes: https://mariadb.com/kb/en/library/mariadb-10217-release-notes/

GrahamcOfBorg · 2018-08-17T15:35:15Z

Success on aarch64-linux (full log)

Attempted: mariadb

Partial log (click to expand)

/nix/store/7yy2gaw4r74va2jq9k764xfb93k9vxc1-mariadb-10.2.17

GrahamcOfBorg · 2018-08-17T15:35:25Z

Success on x86_64-darwin (full log)

Attempted: mariadb

Partial log (click to expand)

/nix/store/bprmjz5liv21c04ki8fdas3q04a7njx6-mariadb-10.2.17

GrahamcOfBorg · 2018-08-17T16:05:09Z

Timed out, unknown build status on x86_64-linux (full log)

Attempted: mariadb

Partial log (click to expand)

[ 78%] Building CXX object storage/perfschema/CMakeFiles/perfschema_embedded.dir/pfs_column_values.cc.o
[ 78%] Building CXX object storage/perfschema/CMakeFiles/perfschema_embedded.dir/pfs_con_slice.cc.o
[ 78%] Building CXX object storage/perfschema/CMakeFiles/perfschema_embedded.dir/pfs_defaults.cc.o
[ 78%] Building CXX object storage/perfschema/CMakeFiles/perfschema_embedded.dir/pfs_digest.cc.o
[ 78%] Linking CXX static library libpfs_server_stubs.a
[ 78%] Built target pfs_server_stubs
Scanning dependencies of target rocksdb_aux_lib
[ 78%] Building CXX object storage/rocksdb/CMakeFiles/rocksdb_aux_lib.dir/rdb_cf_options.cc.o
building of '/nix/store/f9f5iykgyq5vxjwxwy866h6lxzk3898c-mariadb-10.2.17.drv' timed out after 1800 seconds
error: build of '/nix/store/f9f5iykgyq5vxjwxwy866h6lxzk3898c-mariadb-10.2.17.drv' failed

vcunat · 2018-08-18T06:59:49Z

nixos/tests/mysql.nix

+with import ../lib/testing.nix { inherit system; };
+let
+  packages = {
+    mysql = pkgs.mysql;


I suppose you don't know:

nix-repl> mysql.name "mariadb-10.2.16"

Bump to latest stable version of the 10.2.x branch. Besides many bug fixes the following security related issues have been fixed: - CVE-2018-3060 - CVE-2018-3064 - CVE-2018-3063 - CVE-2018-3058 - CVE-2018-3066 Release notes: https://mariadb.com/kb/en/library/mariadb-10217-release-notes/

xeji · 2018-08-28T15:31:31Z

@andir these "2" tests are the same since mysql is an alias for mariadb. If you really want mysql, use pkgs.mysql57.

andir · 2018-08-28T15:52:16Z

I got that from vcunat's comment. Just didn't have the time to fix it yet.

…

On Tue, 28 Aug 2018, 17:31 xeji, ***@***.***> wrote: @andir <https://github.com/andir> these "2" tests are the same since mysql is an alias for mariadb. If you really want mysql, use pkgs.mysql57. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#45199 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAm_dK63Bi_06rTRVecPr42J8ERRaaOWks5uVWJZgaJpZM4WBDZX> .

xeji · 2018-08-28T16:00:12Z

Great, sorry for the noise.

luzpaz · 2019-02-05T12:47:31Z

Should probably be closed in favor of #44343

vcunat · 2019-02-11T11:30:38Z

This change had been pushed as 5da1d01.

andir added the 1.severity: security label Aug 17, 2018

GrahamcOfBorg added 6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Aug 17, 2018

vcunat reviewed Aug 17, 2018

View reviewed changes

andir added 2 commits August 17, 2018 17:11

nixos/tests/mysql: add mariadb to mysql test

3892256

The NixOS module already covers mariadb so the mysql test can easily be used as a vehicle for mariadb.

andir force-pushed the mariadb branch from 6c3d99c to 04df7df Compare August 17, 2018 15:11

vcunat reviewed Aug 18, 2018

View reviewed changes

vcunat added 2.status: work-in-progress and removed 1.severity: security labels Aug 28, 2018

vcunat closed this Feb 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mariadb: 10.2.16 -> 10.2.17 #45199

mariadb: 10.2.16 -> 10.2.17 #45199

andir commented Aug 17, 2018 •

edited

Loading

andir commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

vcunat Aug 17, 2018

andir Aug 17, 2018

vcunat commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

vcunat Aug 18, 2018

xeji commented Aug 28, 2018

andir commented Aug 28, 2018 via email

xeji commented Aug 28, 2018

luzpaz commented Feb 5, 2019

vcunat commented Feb 11, 2019

mariadb: 10.2.16 -> 10.2.17 #45199

mariadb: 10.2.16 -> 10.2.17 #45199

Conversation

andir commented Aug 17, 2018 • edited Loading

Motivation for this change

Things done

andir commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

vcunat Aug 17, 2018

Choose a reason for hiding this comment

andir Aug 17, 2018

Choose a reason for hiding this comment

vcunat commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

vcunat Aug 18, 2018

Choose a reason for hiding this comment

xeji commented Aug 28, 2018

andir commented Aug 28, 2018 via email

xeji commented Aug 28, 2018

luzpaz commented Feb 5, 2019

vcunat commented Feb 11, 2019

andir commented Aug 17, 2018 •

edited

Loading