Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdal: allow version 1.11 on Darwin #45162

Merged
merged 1 commit into from Aug 16, 2018
Merged

gdal: allow version 1.11 on Darwin #45162

merged 1 commit into from Aug 16, 2018

Conversation

Calvin-L
Copy link
Contributor

The GDAL 1.11 derivation has been Linux-only for its entire life, but builds just fine on Mac.

Motivation for this change

GDAL 1.11 is an upstream dependency for a project I am working with. Currently I need to set allowUnsupportedSystem = true; in my Nix configuration to use it on my Mac---but it seems to work just fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Calvin-L
gdal: allow version 1.11 on Darwin
ebc5284 
The GDAL 1.11 derivation has been Linux-only for its entire life, but builds just fine on Mac.
@LnL7
Copy link
Member

LnL7 commented Aug 16, 2018

@GrahamcOfBorg build gdal

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gdal

Partial log (click to expand)

/nix/store/c6bdm70lf3jz4hd1rv34vddfld0k2g86-gdal-2.3.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gdal

Partial log (click to expand)

copying path '/nix/store/3gq8730kbj9fgf5nk9anvg90c27vxsf1-hdf-4.2.14-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/lwxj297jmlnn7z7qagjyzkcg470rh3g2-netcdf-4.6.1' from 'https://cache.nixos.org'...
copying path '/nix/store/wfx419ahpb540n57yi3iayjlqviv93bs-poppler-glib-0.67.0' from 'https://cache.nixos.org'...
copying path '/nix/store/jx1jxwd849nqpaxkkrvpbvix4lja2bs5-proj-4.9.3' from 'https://cache.nixos.org'...
copying path '/nix/store/l5n3p54yizhbh427jbsalw89zk9zmc66-poppler-glib-0.67.0-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/xqq0527vjnakx94asm9yjxxv4l4sfzyk-libgeotiff-1.4.2' from 'https://cache.nixos.org'...
copying path '/nix/store/im7814w6b2hniwxmraa7a1bibvknzhbw-libspatialite-4.3.0a' from 'https://cache.nixos.org'...
copying path '/nix/store/y9ii767ibsws2frma7cbnamhy666lrxm-qhull-2016.1' from 'https://cache.nixos.org'...
copying path '/nix/store/cq1lxzkqs5bagpar0wqrn91k8qaqsv6f-gdal-2.3.1' from 'https://cache.nixos.org'...
/nix/store/cq1lxzkqs5bagpar0wqrn91k8qaqsv6f-gdal-2.3.1

LnL7
LnL7 approved these changes Aug 16, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LnL7 LnL7 merged commit 8395f9a into NixOS:master Aug 16, 2018
@Calvin-L Calvin-L deleted the patch-2 branch August 16, 2018 23:56
@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: gdal

Partial log (click to expand)

     VOIDP key                       /* IN: object to add to the list */
     ^~~~~
/build/hdf-4.2.14/hdf/src/tbbt.h:219:36: error: unknown type name 'VOIDP'
                 (TBBT_TREE * tree, VOIDP key, TBBT_NODE ** pp);
                                    ^~~~~
/build/hdf-4.2.14/hdf/src/hchunks.h:206:10: error: unknown type name 'int32'; did you mean 'int'?
          int32 *orig_size  /* OUT: size of non-compressed data */);
building of '/nix/store/nq55f8bi0mrqj4b0gixdw633ycfv606a-hdf-4.2.14.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/32hvi7zjxz3wfym22fs7cqqxw1f9rhcn-gdal-2.3.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/32hvi7zjxz3wfym22fs7cqqxw1f9rhcn-gdal-2.3.1.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Calvin-L @LnL7 @GrahamcOfBorg @Janik-Haag