Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc: fix darwin build #45143

Merged
merged 2 commits into from Aug 17, 2018
Merged

grpc: fix darwin build #45143

merged 2 commits into from Aug 17, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Aug 16, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of some binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Aug 16, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: c-ares, grpc

Partial log (click to expand)

/nix/store/ql77rv8b1c0cp9b2r8h76shg65mhgn8w-c-ares-1.14.0
/nix/store/c00fkd0kqfc4vpgjm71s9rj7ydhhwwhr-grpc-1.10.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: c-ares, grpc

Partial log (click to expand)

shrinking /nix/store/9snzrahs51i1yrn37dan3s65asf228sn-grpc-1.10.1/bin/grpc_cpp_plugin
shrinking /nix/store/9snzrahs51i1yrn37dan3s65asf228sn-grpc-1.10.1/bin/grpc_verify_jwt
shrinking /nix/store/9snzrahs51i1yrn37dan3s65asf228sn-grpc-1.10.1/bin/grpc_create_jwt
shrinking /nix/store/9snzrahs51i1yrn37dan3s65asf228sn-grpc-1.10.1/bin/grpc_objective_c_plugin
shrinking /nix/store/9snzrahs51i1yrn37dan3s65asf228sn-grpc-1.10.1/bin/check_epollexclusive
shrinking /nix/store/9snzrahs51i1yrn37dan3s65asf228sn-grpc-1.10.1/lib/libgrpc_csharp_ext.so
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9snzrahs51i1yrn37dan3s65asf228sn-grpc-1.10.1/lib  /nix/store/9snzrahs51i1yrn37dan3s65asf228sn-grpc-1.10.1/bin
patching script interpreter paths in /nix/store/9snzrahs51i1yrn37dan3s65asf228sn-grpc-1.10.1
checking for references to /build in /nix/store/9snzrahs51i1yrn37dan3s65asf228sn-grpc-1.10.1...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: c-ares, grpc

Partial log (click to expand)

shrinking /nix/store/4pf6mpz5dwksq3am4ivg832lplhcjdin-grpc-1.10.1/bin/grpc_print_google_default_creds_token
shrinking /nix/store/4pf6mpz5dwksq3am4ivg832lplhcjdin-grpc-1.10.1/bin/grpc_create_jwt
shrinking /nix/store/4pf6mpz5dwksq3am4ivg832lplhcjdin-grpc-1.10.1/bin/check_epollexclusive
shrinking /nix/store/4pf6mpz5dwksq3am4ivg832lplhcjdin-grpc-1.10.1/lib/libgrpc_csharp_ext.so
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4pf6mpz5dwksq3am4ivg832lplhcjdin-grpc-1.10.1/lib  /nix/store/4pf6mpz5dwksq3am4ivg832lplhcjdin-grpc-1.10.1/bin
patching script interpreter paths in /nix/store/4pf6mpz5dwksq3am4ivg832lplhcjdin-grpc-1.10.1
checking for references to /build in /nix/store/4pf6mpz5dwksq3am4ivg832lplhcjdin-grpc-1.10.1...
/nix/store/sm19fsm8r4gpnpfcaswx2nxppallv8pn-c-ares-1.14.0
/nix/store/4pf6mpz5dwksq3am4ivg832lplhcjdin-grpc-1.10.1

@xeji xeji merged commit 7569513 into NixOS:master Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @GrahamcOfBorg @xeji