vegur: init at 0.701 #45164
Merged
vegur: init at 0.701 #45164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success on aarch64-linux (full log) Attempted: vegur Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: vegur Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: vegur Partial log (click to expand)
|
infinisil
reviewed
Aug 18, 2018
pkgs/data/fonts/vegur/default.nix
Outdated
| ''; | ||
|
|
||
| installPhase = '' | ||
| unzip vegur.zip |
There was a problem hiding this comment.
Would probably make more sense to move this command to unpackPhase
samueldr
force-pushed
the
font/vegur.701
branch
from
97c35f8
to
e8110fd
Compare
|
Success on aarch64-linux (full log) Attempted: vegur Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: vegur Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: vegur Partial log (click to expand)
|
infinisil
reviewed
Aug 18, 2018
pkgs/data/fonts/vegur/default.nix
Outdated
| installPhase = '' | ||
| mkdir -p $out/share/fonts/Vegur | ||
| for f in *.otf; do | ||
| cp "$f" $out/share/fonts/Vegur |
There was a problem hiding this comment.
Another nitpick: This can also be cp *.otf $out/share/fonts/Vegur
There was a problem hiding this comment.
You're right. For records sake, this comes from another variant where the fonts were patched at the same time.
samueldr
force-pushed
the
font/vegur.701
branch
from
e8110fd
to
ad7c58e
Compare
|
Success on aarch64-linux (full log) Attempted: vegur Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: vegur Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: vegur Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds the font used by the NixOS Logo to the repository.... Except this isn't it!
The font used in the NixOS logo has been updated with different metrics. A Nix derivation for the font matching the metrics of the NixOS logo will be added to the nixos-artwork repository.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)