Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy-protobuf: init at 1.6 #45163

Merged
merged 2 commits into from Aug 23, 2018
Merged

mypy-protobuf: init at 1.6 #45163

merged 2 commits into from Aug 23, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Aug 16, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 requested a review from FRidh as a code owner August 16, 2018 23:37
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: protobuf

Partial log (click to expand)

/nix/store/9jyr78lv9gsp8hia4vwqf3b2fqqs8zd6-protobuf-3.4.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: protobuf

Partial log (click to expand)

/nix/store/pvd4ry1g1dbj0q4pr9qiyrvqy7aakv8v-protobuf-3.4.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: protobuf

Partial log (click to expand)

/nix/store/fhz5rgb1g77l87dvpcrh0kn978bmi04z-protobuf-3.4.1

@LnL7 LnL7 merged commit 51469b7 into NixOS:master Aug 23, 2018
@LnL7 LnL7 deleted the mypy-protobuf branch August 23, 2018 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LnL7 @GrahamcOfBorg