Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: 7.2.8 -> 7.2.9 #45159

Closed
wants to merge 1 commit into from
Closed

php: 7.2.8 -> 7.2.9 #45159

wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/php/versions.

meta.description for php is: '"An HTML-embedded scripting language"'.

Checks done (click to expand)
  • built on NixOS
  • /nix/store/bhn3lnxj31lhidfnsqgkfbpc3bs4lclr-php-7.2.9/bin/phar.phar passed the binary check.
  • /nix/store/bhn3lnxj31lhidfnsqgkfbpc3bs4lclr-php-7.2.9/bin/phar passed the binary check.
  • /nix/store/bhn3lnxj31lhidfnsqgkfbpc3bs4lclr-php-7.2.9/bin/php passed the binary check.
  • /nix/store/bhn3lnxj31lhidfnsqgkfbpc3bs4lclr-php-7.2.9/bin/phpdbg passed the binary check.
  • /nix/store/bhn3lnxj31lhidfnsqgkfbpc3bs4lclr-php-7.2.9/bin/php-cgi passed the binary check.
  • /nix/store/bhn3lnxj31lhidfnsqgkfbpc3bs4lclr-php-7.2.9/bin/pear passed the binary check.
  • /nix/store/bhn3lnxj31lhidfnsqgkfbpc3bs4lclr-php-7.2.9/bin/peardev passed the binary check.
  • /nix/store/bhn3lnxj31lhidfnsqgkfbpc3bs4lclr-php-7.2.9/bin/pecl passed the binary check.
  • /nix/store/bhn3lnxj31lhidfnsqgkfbpc3bs4lclr-php-7.2.9/bin/php-fpm passed the binary check.
  • 9 of 9 passed binary check by having a zero exit code.
  • 0 of 9 passed binary check by having the new version present in output.
  • found 7.2.9 with grep in /nix/store/bhn3lnxj31lhidfnsqgkfbpc3bs4lclr-php-7.2.9
  • directory tree listing: https://gist.github.com/3d70ff099bd850a882bcd90dbf657520
  • du listing: https://gist.github.com/bf785efb2bace9db954a08d722e785e9
Test this build with Cachix (click to expand)

One time setup in nixpkgs Git checkout:

cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:

git fetch r-ryantm && git checkout 153eef2756f9969a3b8d677cf92de7e5a13b75c0 && nix-shell --pure -I nixpkgs=. -p php

cc @globin @etu for testing.

php: 7.2.8 -> 7.2.9
153eef2 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/php/versions.
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: php

Partial log (click to expand)

/private/tmp/nix-build-php-7.2.9.drv-0/php-7.2.9/main/php_config.h:2619:24: note: expanded from macro 'zend_finite'
#define zend_finite(a) finite(a)
                       ^
/nix/store/ab07pdqrpdw3vadwbzazvb4pwdkgafqb-libc++-5.0.2/include/c++/v1/math.h:439:1: note: 'isfinite' declared here
isfinite(_A1 __lcpp_x) _NOEXCEPT
^
2 errors generated.
make: *** [Makefile:1177: ext/intl/intl_convertcpp.lo] Error 1
builder for '/nix/store/xxcrz3kwg51ik4y903kxdg3a6z0726m0-php-7.2.9.drv' failed with exit code 2
error: build of '/nix/store/xxcrz3kwg51ik4y903kxdg3a6z0726m0-php-7.2.9.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php

Partial log (click to expand)

/nix/store/jamnav8yf1q9sxk3z8jf1f2nbx0xby56-php-7.2.9/bin/pear: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/jamnav8yf1q9sxk3z8jf1f2nbx0xby56-php-7.2.9/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/jamnav8yf1q9sxk3z8jf1f2nbx0xby56-php-7.2.9/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/jamnav8yf1q9sxk3z8jf1f2nbx0xby56-php-7.2.9...
moving /nix/store/jamnav8yf1q9sxk3z8jf1f2nbx0xby56-php-7.2.9/sbin/* to /nix/store/jamnav8yf1q9sxk3z8jf1f2nbx0xby56-php-7.2.9/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/qag067ffl990za7fhmzap3c20ifk4za0-php-7.2.9-dev
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/qag067ffl990za7fhmzap3c20ifk4za0-php-7.2.9-dev
checking for references to /build in /nix/store/qag067ffl990za7fhmzap3c20ifk4za0-php-7.2.9-dev...
/nix/store/jamnav8yf1q9sxk3z8jf1f2nbx0xby56-php-7.2.9

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php

Partial log (click to expand)

/nix/store/cdm30aq49sq5w059i5zbj4a25qkai0y4-php-7.2.9/bin/pear: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/cdm30aq49sq5w059i5zbj4a25qkai0y4-php-7.2.9/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/cdm30aq49sq5w059i5zbj4a25qkai0y4-php-7.2.9/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/cdm30aq49sq5w059i5zbj4a25qkai0y4-php-7.2.9...
moving /nix/store/cdm30aq49sq5w059i5zbj4a25qkai0y4-php-7.2.9/sbin/* to /nix/store/cdm30aq49sq5w059i5zbj4a25qkai0y4-php-7.2.9/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/vik93qfk3j6fs8nnf2wjr1rmw9w1hc6c-php-7.2.9-dev
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/vik93qfk3j6fs8nnf2wjr1rmw9w1hc6c-php-7.2.9-dev
checking for references to /build in /nix/store/vik93qfk3j6fs8nnf2wjr1rmw9w1hc6c-php-7.2.9-dev...
/nix/store/cdm30aq49sq5w059i5zbj4a25qkai0y4-php-7.2.9

@etu
Copy link
Contributor

etu commented Aug 18, 2018

Changelog here: https://secure.php.net/ChangeLog-7.php#7.2.9

Looks like there's some memory leaks and a segfault fixed, and I'd say that's reason enough to backport it to stable.

@xeji
Copy link
Contributor

xeji commented Aug 18, 2018

Darwin failure looks like a regression: https://hydra.nixos.org/job/nixpkgs/trunk/php72.x86_64-darwin
and should be fixed before merging this.

xeji
xeji suggested changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix darwin build

@etu etu mentioned this pull request Sep 15, 2018
Merged
9 tasks
@xeji
Copy link
Contributor

xeji commented Sep 15, 2018

superseded by #46694

@xeji xeji closed this Sep 15, 2018
@r-ryantm r-ryantm deleted the auto-update/php branch September 20, 2018 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r-ryantm @GrahamcOfBorg @etu @xeji