Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostgreSQL 10.5, 9.6.10, 9.5.14, 9.4.19 & 9.3.24 updates. #45146

Merged
merged 5 commits into from Aug 21, 2018
Merged

PostgreSQL 10.5, 9.6.10, 9.5.14, 9.4.19 & 9.3.24 updates. #45146

merged 5 commits into from Aug 21, 2018

Conversation

andir
Copy link
Member

@andir andir commented Aug 16, 2018 •
edited

Motivation for this change

PostgreSQL 10.5, 9.6.10, 9.5.14, 9.4.19 & 9.3.24 updates.

Fixes CVE-2018-10915 & CVE-2018-10925

Release notes: https://www.postgresql.org/about/news/1878/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@andir
postgresql100: 10.4 -> 10.5
1c4fc1d 
Fixes CVE-2018-10915 & CVE-2018-10925

Release notes: https://www.postgresql.org/docs/current/static/release-10-5.html
@andir
postgresql96: 9.6.9 -> 9.6.10
94c3589 
Fixes CVE-2018-10915 & CVE-2018-10925

Release notes: https://www.postgresql.org/docs/current/static/release-9-6-10.html
@andir
postgresql95: 9.5.13 -> 9.5.14
98d8db4 
Fixes CVE-2018-10915 & CVE-2018-10925

Release notes: https://www.postgresql.org/docs/current/static/release-9-5-14.html
@andir
postgresql94: 9.4.18 -> 9.4.19
2abb00e 
Fixes CVE-2018-10915 & CVE-2018-10925

Release notes: https://www.postgresql.org/docs/current/static/release-9-4-19.html
@andir
postgresql93: 9.3.23 -> 9.3.24
5de601e 
Fixes CVE-2018-10915 & CVE-2018-10925

Release notes: https://www.postgresql.org/docs/current/static/release-9-3-24.html
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: postgresql100, postgresql93, postgresql94, postgresql95, postgresql96

Partial log (click to expand)

checking for references to /build in /nix/store/ahirg9dm1885bca8x6rr7bh4wmjvjvx8-postgresql-9.6.10-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/dcfs2pqnfshi86pr8xkbjfidmh3353xb-postgresql-9.6.10-doc
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/dcfs2pqnfshi86pr8xkbjfidmh3353xb-postgresql-9.6.10-doc
checking for references to /build in /nix/store/dcfs2pqnfshi86pr8xkbjfidmh3353xb-postgresql-9.6.10-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/cpg972xhlwy7bazfc9ikmnssz8n2nccd-postgresql-9.6.10-man
gzipping man pages under /nix/store/cpg972xhlwy7bazfc9ikmnssz8n2nccd-postgresql-9.6.10-man/share/man/
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/cpg972xhlwy7bazfc9ikmnssz8n2nccd-postgresql-9.6.10-man
checking for references to /build in /nix/store/cpg972xhlwy7bazfc9ikmnssz8n2nccd-postgresql-9.6.10-man...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: postgresql100, postgresql93, postgresql94, postgresql95, postgresql96

Partial log (click to expand)

/nix/store/pccaagnckcd5vxcxswdmlwyw11g2ilm4-postgresql-9.6.10/lib/pgxs/config/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/hp9yq2m1i066irvasv20zr2lmj54fk9h-bash-4.4-p23/bin/sh"
/nix/store/pccaagnckcd5vxcxswdmlwyw11g2ilm4-postgresql-9.6.10/lib/pgxs/config/missing: interpreter directive changed from " /bin/sh" to "/nix/store/hp9yq2m1i066irvasv20zr2lmj54fk9h-bash-4.4-p23/bin/sh"
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/qlx3yr2jgrrv7g73dy8zszjf2y8llghh-postgresql-9.6.10-lib/lib
patching script interpreter paths in /nix/store/qlx3yr2jgrrv7g73dy8zszjf2y8llghh-postgresql-9.6.10-lib
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/yg4m27gx0sz0kpvjr06rnp17cazx1yll-postgresql-9.6.10-doc
gzipping man pages under /nix/store/vwivbb87zjrfj9wmlvcn6a26jcsdrq0n-postgresql-9.6.10-man/share/man/
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/vwivbb87zjrfj9wmlvcn6a26jcsdrq0n-postgresql-9.6.10-man

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: postgresql100, postgresql93, postgresql94, postgresql95, postgresql96

Partial log (click to expand)

gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -O2 -I../../../../src/include -D_GNU_SOURCE -I/nix/store/z0mhz75i2dlabbwqzrmbd9h4k4ff5phd-libxml2-2.9.8-dev/include/libxml2   -c -o preptlist.o preptlist.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -O2 -I../../../../src/include -D_GNU_SOURCE -I/nix/store/z0mhz75i2dlabbwqzrmbd9h4k4ff5phd-libxml2-2.9.8-dev/include/libxml2   -c -o prepsecurity.o prepsecurity.c
building of '/nix/store/j5kk4r8vwalc1lxjx7b181z4vh57n1fn-postgresql-10.5.drv' timed out after 3600 seconds
building of '/nix/store/p3g29smx18qgh369k9rksjyp1aw5brn0-postgresql-9.6.10.drv' timed out after 3600 seconds
( echo src/backend/libpq/be-fsstubs.o src/backend/libpq/be-secure.o src/backend/libpq/auth.o src/backend/libpq/crypt.o src/backend/libpq/hba.o src/backend/libpq/ip.o src/backend/libpq/md5.o src/backend/libpq/pqcomm.o src/backend/libpq/pqformat.o src/backend/libpq/pqsignal.o ) >objfiles.txt
building of '/nix/store/axcyh5a454nd71ka3cg61kn8dnbdk2k8-postgresql-9.3.24.drv' timed out after 3600 seconds
building of '/nix/store/lyq3jd1nzr2ay1nps7zhm67aq060m0j1-postgresql-9.5.14.drv' timed out after 3600 seconds
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -O2 -I../../../../src/include -D_GNU_SOURCE -I/nix/store/z0mhz75i2dlabbwqzrmbd9h4k4ff5phd-libxml2-2.9.8-dev/include/libxml2   -c -o prepqual.o prepqual.c
building of '/nix/store/86r754dyvb7f2lkzb8a3598diczw3br4-postgresql-9.4.19.drv' timed out after 3600 seconds
error: build of '/nix/store/86r754dyvb7f2lkzb8a3598diczw3br4-postgresql-9.4.19.drv', '/nix/store/axcyh5a454nd71ka3cg61kn8dnbdk2k8-postgresql-9.3.24.drv', '/nix/store/j5kk4r8vwalc1lxjx7b181z4vh57n1fn-postgresql-10.5.drv', '/nix/store/lyq3jd1nzr2ay1nps7zhm67aq060m0j1-postgresql-9.5.14.drv', '/nix/store/p3g29smx18qgh369k9rksjyp1aw5brn0-postgresql-9.6.10.drv' failed

@andir
Copy link
Member Author

andir commented Aug 17, 2018

@GrahamcOfBorg test postgresql

@GrahamcOfBorg
Copy link

Success on x86_64-linux

Attempted: tests.postgresql

No partial log is available.

@GrahamcOfBorg
Copy link

Success on aarch64-linux

Attempted: tests.postgresql

No partial log is available.

vcunat added a commit that referenced this pull request Aug 18, 2018
@vcunat
Merge #45146 into staging: postgresql security updates
c13bbda
@vcunat
Copy link
Member

vcunat commented Aug 18, 2018

(staged)

@vcunat vcunat merged commit 5de601e into NixOS:master Aug 21, 2018
@andir andir deleted the postgresql branch August 22, 2018 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @GrahamcOfBorg @vcunat