Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.03] PostgreSQL 10.5, 9.6.10, 9.5.14, 9.4.19 & 9.3.24 updates #45147

Merged
merged 5 commits into from Aug 17, 2018
Merged

[18.03] PostgreSQL 10.5, 9.6.10, 9.5.14, 9.4.19 & 9.3.24 updates #45147

merged 5 commits into from Aug 17, 2018

Conversation

andir
Copy link
Member

@andir andir commented Aug 16, 2018 •
edited

Motivation for this change

PostgreSQL 10.5, 9.6.10, 9.5.14, 9.4.19 & 9.3.24 updates.

Fixes CVE-2018-10915 & CVE-2018-10925

Release notes: https://www.postgresql.org/about/news/1878/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@andir
postgresql100: 10.4 -> 10.5
520b2cd 
Fixes CVE-2018-10915 & CVE-2018-10925

Release notes: https://www.postgresql.org/docs/current/static/release-10-5.html

(cherry picked from commit 1c4fc1d)
@andir
postgresql96: 9.6.9 -> 9.6.10
6afac1b 
Fixes CVE-2018-10915 & CVE-2018-10925

Release notes: https://www.postgresql.org/docs/current/static/release-9-6-10.html

(cherry picked from commit 94c3589)
@andir
postgresql95: 9.5.13 -> 9.5.14
050f59c 
Fixes CVE-2018-10915 & CVE-2018-10925

Release notes: https://www.postgresql.org/docs/current/static/release-9-5-14.html

(cherry picked from commit 98d8db4)
@andir
postgresql94: 9.4.18 -> 9.4.19
e2eda22 
Fixes CVE-2018-10915 & CVE-2018-10925

Release notes: https://www.postgresql.org/docs/current/static/release-9-4-19.html

(cherry picked from commit 2abb00e)
@andir
postgresql93: 9.3.23 -> 9.3.24
cddb625 
Fixes CVE-2018-10915 & CVE-2018-10925

Release notes: https://www.postgresql.org/docs/current/static/release-9-3-24.html

(cherry picked from commit 5de601e)
@andir andir changed the title 18.03/postgresql [18.03] PostgreSQL 10.5, 9.6.10, 9.5.14, 9.4.19 & 9.3.24 updates Aug 16, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: postgresql100, postgresql93, postgresql94, postgresql95, postgresql96

Partial log (click to expand)

checking for references to /build in /nix/store/aaaq0jaijgddbb55bn5f4npnf9z75hqy-postgresql-9.6.10-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/vmw92jcsfaknvwdlcb14bmidyfazb8jz-postgresql-9.6.10-doc
strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/vmw92jcsfaknvwdlcb14bmidyfazb8jz-postgresql-9.6.10-doc
checking for references to /build in /nix/store/vmw92jcsfaknvwdlcb14bmidyfazb8jz-postgresql-9.6.10-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/nskz497gbxps6p4ba30xyir0r3cgbq17-postgresql-9.6.10-man
gzipping man pages under /nix/store/nskz497gbxps6p4ba30xyir0r3cgbq17-postgresql-9.6.10-man/share/man/
strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/nskz497gbxps6p4ba30xyir0r3cgbq17-postgresql-9.6.10-man
checking for references to /build in /nix/store/nskz497gbxps6p4ba30xyir0r3cgbq17-postgresql-9.6.10-man...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: postgresql100, postgresql93, postgresql94, postgresql95, postgresql96

Partial log (click to expand)

/nix/store/5f08rhph9z861baqamplvlic8xfknz0m-postgresql-9.6.10/lib/pgxs/config/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/k5n19ccijsqdi5dwgblcck8x6b7ymlml-bash-4.4-p12/bin/sh"
/nix/store/5f08rhph9z861baqamplvlic8xfknz0m-postgresql-9.6.10/lib/pgxs/config/missing: interpreter directive changed from " /bin/sh" to "/nix/store/k5n19ccijsqdi5dwgblcck8x6b7ymlml-bash-4.4-p12/bin/sh"
strip is /nix/store/q4mjflkrrpvajlawjngyr0d1bhpyb5ij-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/aii7il84lzpfjzpp50dw5ps35gl0vd0s-postgresql-9.6.10-lib/lib
patching script interpreter paths in /nix/store/aii7il84lzpfjzpp50dw5ps35gl0vd0s-postgresql-9.6.10-lib
strip is /nix/store/q4mjflkrrpvajlawjngyr0d1bhpyb5ij-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/sgmsb9x3fxp8523w87izlsc8xrqj4c0r-postgresql-9.6.10-doc
gzipping man pages under /nix/store/sqffccwq5gjvdyjfxjyiqqx6mlkq5n0h-postgresql-9.6.10-man/share/man/
strip is /nix/store/q4mjflkrrpvajlawjngyr0d1bhpyb5ij-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/sqffccwq5gjvdyjfxjyiqqx6mlkq5n0h-postgresql-9.6.10-man

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: postgresql100, postgresql93, postgresql94, postgresql95, postgresql96

Partial log (click to expand)

make[2]: Leaving directory '/build/postgresql-10.5/contrib/adminpack'
make -C xml2 all
make[2]: Entering directory '/build/postgresql-10.5/contrib/xml2'
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -O2 -fPIC -I. -I. -I../../src/include  -D_GNU_SOURCE -I/nix/store/jja6lbqjbdjpmv40r4k2kx3c1lvg37yv-libxml2-2.9.7-dev/include/libxml2   -c -o xpath.o xpath.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -O2 -I../../../src/include -D_GNU_SOURCE -I/nix/store/jja6lbqjbdjpmv40r4k2kx3c1lvg37yv-libxml2-2.9.7-dev/include/libxml2   -c -o print.o print.c
building of '/nix/store/6ckjccpymrg5sh6v8kpqahj07kl8r537-postgresql-10.5.drv' timed out after 3600 seconds
building of '/nix/store/gx0cyx7fryq69hkdzizbw91lpiyafcmk-postgresql-9.3.24.drv' timed out after 3600 seconds
building of '/nix/store/461547x9a78yhijgcjr25dr2fw1816sd-postgresql-9.5.14.drv' timed out after 3600 seconds
building of '/nix/store/jrfyybfkd6gfmjw97b2zwl6a0lllyp9w-postgresql-9.6.10.drv' timed out after 3600 seconds
error: build of '/nix/store/461547x9a78yhijgcjr25dr2fw1816sd-postgresql-9.5.14.drv', '/nix/store/6ckjccpymrg5sh6v8kpqahj07kl8r537-postgresql-10.5.drv', '/nix/store/gx0cyx7fryq69hkdzizbw91lpiyafcmk-postgresql-9.3.24.drv', '/nix/store/jrfyybfkd6gfmjw97b2zwl6a0lllyp9w-postgresql-9.6.10.drv' failed

@andir
Copy link
Member Author

andir commented Aug 17, 2018

@GrahamcOfBorg test postgresql

@GrahamcOfBorg
Copy link

Success on x86_64-linux

Attempted: tests.postgresql

No partial log is available.

@GrahamcOfBorg
Copy link

Success on aarch64-linux

Attempted: tests.postgresql

No partial log is available.

vcunat
vcunat approved these changes Aug 17, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take it through staging.

vcunat added a commit that referenced this pull request Aug 17, 2018
@vcunat
Merge #45147 into staging-18.03: postgresql security
549d76c
@vcunat vcunat merged commit cddb625 into NixOS:release-18.03 Aug 17, 2018
@andir andir deleted the 18.03/postgresql branch August 17, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @GrahamcOfBorg @vcunat