ghc: Use 8.2.2 binary for boot, no parallel builds on aarch64. #45166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisWhitaker
requested review from
basvandijk,
peti and
ryantm
as code owners
peti
requested changes
Aug 17, 2018
|
Closed in favor of #45313. |
|
@TravisWhitaker, please don't close and re-create PRs for the exact same topic. Instead, please modify the existing PR so that the history etc. remains intact. |
|
I am not aware of a way to change which branch an existing PR is asking to merge changes into. |
|
@TravisWhitaker press "Edit" besides the PR title then I believe a field becomes visible with which you can change the base. Then also make sure to rebase your branch on the new base and force-push it. |
|
Ah thanks! That's really handy! Sorry for missing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
GHC 8.2.1 is rather broken. Upstream's build system actually complains if you attempt to build with it (see this bug). This is especially true of aarch64. It would be nice to bootstrap with upstream's binary 8.2.2 instead.
This bug also severely affects GHC on aarch64, and without disabling parallel building GHC is next to useless on that platform. Until a fix for that bug makes it into a release, it would be better to disable parallel builds on aarch64.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)