Firefox on Darwin #44186
Merged
Firefox on Darwin #44186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think in the past we've sort of stayed away from trying to have well-packaged GUI apps on Darwin. I'd like to get some feedback from the two "high level" maintainers on that front on if they're interested in changing that direction: @LnL7 @copumpkin |
|
Success on aarch64-linux (full log) Attempted: libuv, xcbuild The following builds were skipped because they don't evaluate on aarch64-linux: darwin.objc4 Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: libuv, xcbuild The following builds were skipped because they don't evaluate on x86_64-linux: darwin.objc4 Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: darwin.objc4, libuv, xcbuild Partial log (click to expand)
|
|
Yeah, the no GUI apps thing wasn't really deliberate though. It mostly resulted from the lack of a viable FOSS nib/xib processing toolchain and general lack of good support from the resulting .apps (we've discussed possible strategies for integrating them into I can't speak for @LnL7, but I definitely welcome (erm, this is awesome) seeing more working GUI apps on Darwin, especially of the flavor that don't require xcode to build 😄 |
|
Success on x86_64-darwin (full log) Attempted: darwin.objc4, libuv, xcbuild Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: libuv, xcbuild The following builds were skipped because they don't evaluate on x86_64-linux: darwin.objc4 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: libuv, xcbuild The following builds were skipped because they don't evaluate on aarch64-linux: darwin.objc4 Partial log (click to expand)
|
LnL7
reviewed
Aug 1, 2018
| --install) ;; # noop | ||
| esac | ||
| shift | ||
| done | ||
| ''; | ||
|
|
||
| xcrun = writeText "xcrun" '' | ||
| #!/usr/bin/env sh | ||
| #!${bash}/bin/sh |
There was a problem hiding this comment.
Thanks! Can change to that.
| # uses LLVM's libclang. To make sure all necessary flags are | ||
| # included we need to look in a few places. | ||
| # TODO: generalize this process for other use-cases. | ||
| echo "ac_add_options BINDGEN_CFLAGS='$(< ${stdenv.cc}/nix-support/libc-cflags) $(< ${stdenv.cc}/nix-support/cc-cflags) ${stdenv.cc.default_cxx_stdlib_compile} -idirafter ${llvmPackages.clang.cc}/lib/clang/${lib.getVersion llvmPackages.clang}/include $NIX_CFLAGS_COMPILE'" >> $MOZCONFIG |
|
I don't have a problem with adding GUI applications. That said they generally seem to be much harder to maintain so if it's too much of a burden we shouldn't keep it in the release blockers, but let's just see how it goes. |
matthewbauer
force-pushed
the
firefox
branch
3 times, most recently
from
9525964
to
a0bea32
Compare
|
Success on aarch64-linux (full log) Attempted: xcbuild Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: xcbuild Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: xcbuild Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: xcbuild Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: xcbuild Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: xcbuild Partial log (click to expand)
|
GrahamcOfBorg
added
6.topic: erlang
6.topic: fetch
6.topic: GNOME
|
Success on x86_64-linux (full log) Attempted: xcbuild Partial log (click to expand)
|
|
Very exciting, thanks again! |
|
|
There's also |
|
Yeah it can default to /bin. Sorry forgot about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is my working attempt to get Firefox working on Darwin/macOS. This will fix #30285.
Unfortunately this is a mass rebuild because of 0078e82ac240d88e3a20afcbf134904cbf920893. Unless there is legitimate reason for leaving it out I will probably just push that commit to staging. Anyway I am still waiting on things here but should be ready to go in a day or two.