Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parity: 1.10.8 -> 1.11.8; parity-beta: init at 2.0.1 #44170

Merged
merged 4 commits into from Aug 3, 2018
Merged

parity: 1.10.8 -> 1.11.8; parity-beta: init at 2.0.1 #44170

merged 4 commits into from Aug 3, 2018

Conversation

akru
Copy link
Contributor

@akru akru commented Jul 28, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@akru akru changed the title parity: 1.10.8 -> 1.11.7 [WIP] parity: 1.10.8 -> 1.11.7 Jul 28, 2018
@akru akru changed the title [WIP] parity: 1.10.8 -> 1.11.7 parity: 1.10.8 -> 1.11.7 Jul 28, 2018
@akru akru changed the title parity: 1.10.8 -> 1.11.7 parity: 1.10.8 -> 1.11.8; parity-beta: init at 2.0.1 Jul 28, 2018
General-Beck
General-Beck approved these changes Jul 28, 2018
View reviewed changes
Copy link

@General-Beck General-Beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake 3.1+

Mic92
Mic92 reviewed Jul 29, 2018
View reviewed changes
pkgs/applications/altcoins/default.nix
@@ -86,6 +86,7 @@ rec {
};

parity = callPackage ./parity { };
parity-beta = callPackage ./parity/beta.nix { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you intend to keep this package up to date? I ask because nightly builds that we had in nixpkgs tend to bitrot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll update beta according to paritytech release policy in the same time as stable release.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@xeji
Copy link
Contributor

xeji commented Aug 2, 2018

@GrahamcOfBorg build parity parity-beta

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: parity, parity-beta

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: parity, parity-beta

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1m2bci2svxzqa9ihgvwyif7800gg5v39-parity-1.11.8
shrinking /nix/store/1m2bci2svxzqa9ihgvwyif7800gg5v39-parity-1.11.8/bin/librlp_derive.so
shrinking /nix/store/1m2bci2svxzqa9ihgvwyif7800gg5v39-parity-1.11.8/bin/parity
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1m2bci2svxzqa9ihgvwyif7800gg5v39-parity-1.11.8/bin
patching script interpreter paths in /nix/store/1m2bci2svxzqa9ihgvwyif7800gg5v39-parity-1.11.8
checking for references to /build in /nix/store/1m2bci2svxzqa9ihgvwyif7800gg5v39-parity-1.11.8...
error: build of '/nix/store/xq65sw2njcaywgakyxzvl5pw2hv7fm8q-parity-2.0.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: parity, parity-beta

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/p45xfcizygjbmnb5ji2g1bcjlpdig7q3-parity-2.0.1
shrinking /nix/store/p45xfcizygjbmnb5ji2g1bcjlpdig7q3-parity-2.0.1/bin/parity
shrinking /nix/store/p45xfcizygjbmnb5ji2g1bcjlpdig7q3-parity-2.0.1/bin/librlp_derive.so
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p45xfcizygjbmnb5ji2g1bcjlpdig7q3-parity-2.0.1/bin
patching script interpreter paths in /nix/store/p45xfcizygjbmnb5ji2g1bcjlpdig7q3-parity-2.0.1
checking for references to /build in /nix/store/p45xfcizygjbmnb5ji2g1bcjlpdig7q3-parity-2.0.1...
/nix/store/mrh7p111dglbh5n2gxas666g3wmixrj6-parity-1.11.8
/nix/store/p45xfcizygjbmnb5ji2g1bcjlpdig7q3-parity-2.0.1

@xeji
Copy link
Contributor

xeji commented Aug 2, 2018

parity-beta fails on aarch64, but it could be a temporary error:

thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 11, kind: WouldBlock, message: "Resource temporarily unavailable" }', libcore/result.rs:945:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.
error: Error during translation/LLVM phase.

@xeji
Copy link
Contributor

xeji commented Aug 3, 2018

Let's merge anyway and see what happens on Hydra.

@xeji xeji merged commit 8d708d2 into NixOS:master Aug 3, 2018
@akru akru deleted the parity-1.11 branch August 8, 2018 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@General-Beck General-Beck General-Beck approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@akru @xeji @GrahamcOfBorg @Mic92 @General-Beck