Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports: onboard: fix missing typelibs #44169

Merged
merged 1 commit into from Jul 28, 2018
Merged

Backports: onboard: fix missing typelibs #44169

merged 1 commit into from Jul 28, 2018

Conversation

samueldr
Copy link
Member

Motivation for this change

Backports 0009ae3

This is to fix #43675.

Things done

I have verified that onboard

  • on current tip does not start.
  • starts after applying commit.
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ✔️ NixOS
    • ⬜ macOS
    • ⬜ other Linux distributions
  • ⬜ Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • ⬜ Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • ✔️ Tested execution of all binary files (usually in ./result/bin/)
  • ⬜ Determined the impact on package closure size (by running nix path-info -S before and after)
  • ✔️ Fits CONTRIBUTING.md.

@GrahamcOfBorg build onboard

This is trivial to merge, cc @jtojnar

@jtojnar @samueldr
onboard: fix missing typelibs
92262df 
(cherry picked from commit 0009ae3)
@samueldr samueldr changed the base branch from master to release-18.03 July 28, 2018 04:20
@samueldr samueldr changed the title Backport/18.03/xx 0009ae3d Backports: onboard: fix missing typelibs Jul 28, 2018
@samueldr
Copy link
Member Author

🤕 accidentally opened the branch targeting master instead of nixos-18.03 this is why everyone in the whole world has been called to review 😨.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: onboard

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: onboard

Partial log (click to expand)

shrinking /nix/store/i7cjhxf3p320cjqrsl3wfg0zag1idfjz-onboard-1.4.1/lib/python3.6/site-packages/Onboard/osk.cpython-36m-x86_64-linux-gnu.so
gzipping man pages under /nix/store/i7cjhxf3p320cjqrsl3wfg0zag1idfjz-onboard-1.4.1/share/man/
strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/i7cjhxf3p320cjqrsl3wfg0zag1idfjz-onboard-1.4.1/lib  /nix/store/i7cjhxf3p320cjqrsl3wfg0zag1idfjz-onboard-1.4.1/bin
patching script interpreter paths in /nix/store/i7cjhxf3p320cjqrsl3wfg0zag1idfjz-onboard-1.4.1
checking for references to /build in /nix/store/i7cjhxf3p320cjqrsl3wfg0zag1idfjz-onboard-1.4.1...
Wrapping program /nix/store/i7cjhxf3p320cjqrsl3wfg0zag1idfjz-onboard-1.4.1/bin/onboard
Wrapping program /nix/store/i7cjhxf3p320cjqrsl3wfg0zag1idfjz-onboard-1.4.1/bin/onboard-settings
wrapping `/nix/store/i7cjhxf3p320cjqrsl3wfg0zag1idfjz-onboard-1.4.1/bin/.onboard-wrapped'...
wrapping `/nix/store/i7cjhxf3p320cjqrsl3wfg0zag1idfjz-onboard-1.4.1/bin/.onboard-settings-wrapped'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: onboard

Partial log (click to expand)

gzipping man pages under /nix/store/1i33cyw2vvvlhkkadc0dj7v62kzk9psm-onboard-1.4.1/share/man/
strip is /nix/store/hy39vplmzpwckvzxgyhr54dwz0mnfv2p-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/1i33cyw2vvvlhkkadc0dj7v62kzk9psm-onboard-1.4.1/lib  /nix/store/1i33cyw2vvvlhkkadc0dj7v62kzk9psm-onboard-1.4.1/bin
patching script interpreter paths in /nix/store/1i33cyw2vvvlhkkadc0dj7v62kzk9psm-onboard-1.4.1
checking for references to /build in /nix/store/1i33cyw2vvvlhkkadc0dj7v62kzk9psm-onboard-1.4.1...
Wrapping program /nix/store/1i33cyw2vvvlhkkadc0dj7v62kzk9psm-onboard-1.4.1/bin/onboard
Wrapping program /nix/store/1i33cyw2vvvlhkkadc0dj7v62kzk9psm-onboard-1.4.1/bin/onboard-settings
wrapping `/nix/store/1i33cyw2vvvlhkkadc0dj7v62kzk9psm-onboard-1.4.1/bin/.onboard-settings-wrapped'...
wrapping `/nix/store/1i33cyw2vvvlhkkadc0dj7v62kzk9psm-onboard-1.4.1/bin/.onboard-wrapped'...
/nix/store/1i33cyw2vvvlhkkadc0dj7v62kzk9psm-onboard-1.4.1

@FRidh FRidh merged commit acc6971 into NixOS:release-18.03 Jul 28, 2018
@ryantm ryantm removed their request for review July 28, 2018 15:12
@samueldr samueldr deleted the backport/18.03/xx-0009ae3d branch July 30, 2018 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@edolstra edolstra Awaiting requested review from edolstra

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92

@nbp nbp Awaiting requested review from nbp

@peti peti Awaiting requested review from peti

@rycee rycee Awaiting requested review from rycee

@ttuegel ttuegel Awaiting requested review from ttuegel

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samueldr @GrahamcOfBorg @FRidh @jtojnar