Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GEO Weather Sat Max Completions #889

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

Tidal-Stream
Copy link
Contributor

No description provided.

Copy link
Contributor

@Bornholio Bornholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 0 was the intent. So it can be repeated.
Perhaps this is appropriate if a secondary type forces modernization or specific instruments aboard.

@Tidal-Stream
Copy link
Contributor Author

It seems like the intention was to have 6 GEO weather sats to capture the whole planet and repeatable sun-synchronous sats for more precise and localised measurements. This is what the description says at least.

@ec429
Copy link
Contributor

ec429 commented Jul 31, 2018

I think we should give primacy to the description and therefore accept this change.
However (unrelated bug), in my experience this contract is uncompleteable for the same reason as the Earth Observation Satellite one, i.e. that horizontal-distance parameters in CC don't work. I wonder if maybe CC can specify a longitude target rather than using a generated point on the surface?

@Tidal-Stream
Copy link
Contributor Author

Tidal-Stream commented Jul 31, 2018

Are you sure you got the orbit parameters right? It works fine for me no matter the longitude. I agree that it needs a longitude target, otherwise you can put all 6 sats next to each other.
screenshot661

Copy link
Contributor

@Bornholio Bornholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertized

@ec429 ec429 merged commit c639db8 into KSP-RO:Developmental Oct 15, 2018
@Tidal-Stream Tidal-Stream deleted the geo-weather-sat branch October 15, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants