Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eureka-editor: Init at 1.21 #44171

Merged
merged 5 commits into from Aug 16, 2018
Merged

eureka-editor: Init at 1.21 #44171

merged 5 commits into from Aug 16, 2018

Conversation

neonfuz
Copy link
Contributor

@neonfuz neonfuz commented Jul 28, 2018 •
edited

Motivation for this change

Add an editor for DOOM wads. There are several doom engines in nixpkgs, but I haven't seen many (any?) wad editors, and this one is pretty good so I decided to write this package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@neonfuz
Copy link
Contributor Author

neonfuz commented Jul 29, 2018

Maybe this should be in pkgs/applications/editors instead, or pkgs/applications/misc, thoughts?

@MP2E
Copy link

MP2E commented Aug 1, 2018

Nice! A Doom map editor seems to go well with all the ports we have packaged. I think putting it in pkgs/applications/misc would fit best, since that is also where Doomseeker is, but I don't have any strong opinions about where it ends up

@neonfuz
Copy link
Contributor Author

neonfuz commented Aug 2, 2018

I merged myself because the bot failed to merge, not sure if I'm supposed to rebase or anything

@neonfuz
Copy link
Contributor Author

neonfuz commented Aug 2, 2018

yeah oops... forgot to update all-packages.nix, this should merge fine now I think

@joachifm
Copy link
Contributor

joachifm commented Aug 6, 2018

@GrahamcOfBorg build eureka-editor

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: eureka-editor

Partial log (click to expand)

typedef struct Sector  *SPtr;
        ^~~~~~
        class
src/main.cc:55:10: fatal error: 'OSXCalls.h' file not found
#include "OSXCalls.h"
         ^~~~~~~~~~~~
5 warnings and 1 error generated.
make: *** [Makefile:120: obj_linux/main.o] Error 1
builder for '/nix/store/5b36601j7jra216spzlcbz89zrl9j6qr-eureka-editor-1.21.drv' failed with exit code 2
error: build of '/nix/store/5b36601j7jra216spzlcbz89zrl9j6qr-eureka-editor-1.21.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: eureka-editor

Partial log (click to expand)

post-installation fixup
moving /nix/store/hii7gikw1nj3mayp2px1y729k2dd4rr5-eureka-editor-1.21/man to /nix/store/hii7gikw1nj3mayp2px1y729k2dd4rr5-eureka-editor-1.21/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/hii7gikw1nj3mayp2px1y729k2dd4rr5-eureka-editor-1.21
shrinking /nix/store/hii7gikw1nj3mayp2px1y729k2dd4rr5-eureka-editor-1.21/bin/eureka
gzipping man pages under /nix/store/hii7gikw1nj3mayp2px1y729k2dd4rr5-eureka-editor-1.21/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hii7gikw1nj3mayp2px1y729k2dd4rr5-eureka-editor-1.21/bin
patching script interpreter paths in /nix/store/hii7gikw1nj3mayp2px1y729k2dd4rr5-eureka-editor-1.21
checking for references to /build in /nix/store/hii7gikw1nj3mayp2px1y729k2dd4rr5-eureka-editor-1.21...
/nix/store/hii7gikw1nj3mayp2px1y729k2dd4rr5-eureka-editor-1.21

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: eureka-editor

Partial log (click to expand)

[ 96%] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/BinaryStreamTest.cpp.o
building of '/nix/store/vff81n3cngba2ff4h19x0m77rb8ad276-llvm-6.0.1.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/q0gpscjwykqmra28r3zk05y57jlvh4mn-mesa-noglu-18.1.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/8yjsqaqr21zlhc1d3hw5v8762xba1gd9-libGL-1.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/xwizpzqsy403mv293sf20pf3llj6a05c-glu-9.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/l6a0vzc0lq7y5a742cn5sg0wac45vd3s-freeglut-3.0.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/lvjm0v5bvrjnz8ib5icmjvasmrfyckxv-libGLU-combined.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/sxdi9fjnmss8lrq27jc8bmzn7jkk45qn-fltk-1.3.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/x011zinyms5snhv8wgxkjpxg2gjcppkx-eureka-editor-1.21.drv': 2 dependencies couldn't be built
error: build of '/nix/store/x011zinyms5snhv8wgxkjpxg2gjcppkx-eureka-editor-1.21.drv' failed

@joachifm
Copy link
Contributor

joachifm commented Aug 6, 2018

The linux build error looks potentially unrelated, but the macos one seems legit.

@neonfuz
Copy link
Contributor Author

neonfuz commented Aug 7, 2018

There seems to be a osx/ directory in the root of src that I never dealt with. I currently don't have an osx machine so it's a little hard to test osx builds but I'll see if I can figure it out.

@joachifm
Copy link
Contributor

joachifm commented Aug 7, 2018

You can also simply limit the platform list for the time being.

@joachifm joachifm merged commit a2e24ae into NixOS:master Aug 16, 2018
@joachifm
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@neonfuz @MP2E @joachifm @GrahamcOfBorg