Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mustache-go: init at 1.0.1 #44175

Merged
merged 1 commit into from Jul 31, 2018
Merged

mustache-go: init at 1.0.1 #44175

merged 1 commit into from Jul 31, 2018

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Jul 28, 2018

Motivation for this change

AFAIK there was no packaged CLI mustache, only programming languages library.
I choose the go implementation because that was the easiest one to package among the implementations that provided a CLI.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Zimmi48 Zimmi48 mentioned this pull request Jul 28, 2018
Merged
@xeji
Copy link
Contributor

xeji commented Jul 31, 2018

@GrahamcOfBorg build mustache-go

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: mustache-go

Partial log (click to expand)

find: '/nix/store/fz92kam2jjmdvs5mvrn67q08v4nbk76i-mustache-go-1.0.1': No such file or directory
find: '/nix/store/fz92kam2jjmdvs5mvrn67q08v4nbk76i-mustache-go-1.0.1': No such file or directory
find: '/nix/store/fz92kam2jjmdvs5mvrn67q08v4nbk76i-mustache-go-1.0.1': No such file or directory
find: '/nix/store/fz92kam2jjmdvs5mvrn67q08v4nbk76i-mustache-go-1.0.1': No such file or directory
find: '/nix/store/fz92kam2jjmdvs5mvrn67q08v4nbk76i-mustache-go-1.0.1': No such file or directory
find: '/nix/store/fz92kam2jjmdvs5mvrn67q08v4nbk76i-mustache-go-1.0.1': No such file or directory
find: '/nix/store/fz92kam2jjmdvs5mvrn67q08v4nbk76i-mustache-go-1.0.1': No such file or directory
find: '/nix/store/fz92kam2jjmdvs5mvrn67q08v4nbk76i-mustache-go-1.0.1': No such file or directory
find: '/nix/store/fz92kam2jjmdvs5mvrn67q08v4nbk76i-mustache-go-1.0.1': No such file or directory
/nix/store/7gnij2pch19m37czq2d0spv4g13lynpc-mustache-go-1.0.1-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mustache-go

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5d7syzi0f082839cn38prh6pgp41161p-mustache-go-1.0.1-bin
shrinking /nix/store/5d7syzi0f082839cn38prh6pgp41161p-mustache-go-1.0.1-bin/bin/mustache
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5d7syzi0f082839cn38prh6pgp41161p-mustache-go-1.0.1-bin/bin
patching script interpreter paths in /nix/store/5d7syzi0f082839cn38prh6pgp41161p-mustache-go-1.0.1-bin
checking for references to /build in /nix/store/5d7syzi0f082839cn38prh6pgp41161p-mustache-go-1.0.1-bin...
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
/nix/store/5d7syzi0f082839cn38prh6pgp41161p-mustache-go-1.0.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mustache-go

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qh276f9pagi3hy9y5l8li9akbf04941h-mustache-go-1.0.1-bin
shrinking /nix/store/qh276f9pagi3hy9y5l8li9akbf04941h-mustache-go-1.0.1-bin/bin/mustache
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qh276f9pagi3hy9y5l8li9akbf04941h-mustache-go-1.0.1-bin/bin
patching script interpreter paths in /nix/store/qh276f9pagi3hy9y5l8li9akbf04941h-mustache-go-1.0.1-bin
checking for references to /build in /nix/store/qh276f9pagi3hy9y5l8li9akbf04941h-mustache-go-1.0.1-bin...
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
/nix/store/qh276f9pagi3hy9y5l8li9akbf04941h-mustache-go-1.0.1-bin

@xeji xeji merged commit fd03ba8 into NixOS:master Jul 31, 2018
@Zimmi48 Zimmi48 deleted the mustache-go branch July 31, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zimmi48 @xeji @GrahamcOfBorg