Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sddm: use tmpfiles.d to wipe QML cache #43243

Merged
merged 1 commit into from Jul 14, 2018
Merged

sddm: use tmpfiles.d to wipe QML cache #43243

merged 1 commit into from Jul 14, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Upgrades to plasma/sddm/qt would sometimes make sddm segfault and a fix was attempted in dae2600 which does not seem to work.

I am not sure if the reason for the previously mentioned commit not working as intended is because the script that is run has insufficient privileges to actually delete the files or other files in the .cache directory needed to be blown away as well so now we run it using a tmpfiles.d fragment (which runs as root) and we remove everything under the .cache directory.

Cc: @ttuegel as author of the original change, @bkchr, @worldofpeace

Fixes #43241

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously no resistence here.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sddm

Partial log (click to expand)

copying path '/nix/store/04yw8k4vqz2nhgivq41p48ypcml6z0qp-libinput-1.11.0' from 'https://cache.nixos.org'...
copying path '/nix/store/5cz2w25zja5p61y531avkm02wzigd864-qtbase-5.11.1' from 'https://cache.nixos.org'...
copying path '/nix/store/51a693by1pgp3hmwg5jqdvlcdrxihw34-qtbase-5.11.1-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/p0a4y355q1aflsk0ck96hhq2zfcy6p21-qtdeclarative-5.11.1' from 'https://cache.nixos.org'...
copying path '/nix/store/c061k2v33ls33p5d0jjm3y59ps8kklk3-qtsvg-5.11.1' from 'https://cache.nixos.org'...
copying path '/nix/store/nxdcyvsxqrgvdvpcmyjd2jqgply4ipkg-qtsvg-5.11.1-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/3mby8k8p0w9dq5523asgg05nhx1ny9xz-qtxmlpatterns-5.11.1' from 'https://cache.nixos.org'...
copying path '/nix/store/37k30wq5m9k74q7s5drvzjgxkcvps1rm-qtdeclarative-5.11.1-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/dc4spl5nlxsj0wny5v581gxqsiw6fawj-sddm-0.17.0' from 'https://cache.nixos.org'...
/nix/store/dc4spl5nlxsj0wny5v581gxqsiw6fawj-sddm-0.17.0

bkchr
bkchr approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@bkchr bkchr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure why this is happening, as the upstream bug was closed :(
But it is nice to finally have a working solution!

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sddm

Partial log (click to expand)

these paths will be fetched (3.36 MiB download, 4.93 MiB unpacked):
  /nix/store/90m3gv1cai6djd75hqb4487v78jscf70-sddm-0.17.0
copying path '/nix/store/90m3gv1cai6djd75hqb4487v78jscf70-sddm-0.17.0' from 'https://cache.nixos.org'...
/nix/store/90m3gv1cai6djd75hqb4487v78jscf70-sddm-0.17.0

@peterhoeg
Copy link
Member Author

I'd like @ttuegel to ACK this before merging as he might have some additional insights.

@jcrben
Copy link
Contributor

jcrben commented Jul 11, 2018

@bkchr if you have the upstream bug link handy I'd like to read it...

@bkchr
Copy link
Contributor

bkchr commented Jul 11, 2018 •
edited

@jcrben look into the diff, there is the link to the qtbug.

@ttuegel
Copy link
Member

ttuegel commented Jul 14, 2018

This seems fine to me!

Upgrades to plasma/sddm/qt would sometimes make sddm segfault and a fix was attempted in dae2600 which does not seem to work.

At one time it did work; do we know why it stopped working? My concern is that this may stop working too; that's not a barrier to merging, but it would be nice if we could head off future problems.

@ttuegel ttuegel merged commit 5ea799d into NixOS:master Jul 14, 2018
@peterhoeg
Copy link
Member Author

At one time it did work; do we know why it stopped working?

I cannot confirm that the original fix ever worked for me. I remember having the issue and trying out a few different things, only having things work when I manually blew away the cache, then running a version of unstable with your commit but still seeing the problem on the next upgrade.

Manually blowing away the cache directory worked every time though.

@peterhoeg peterhoeg deleted the f/sddmqt branch July 15, 2018 03:43
@bkchr
Copy link
Contributor

bkchr commented Jul 15, 2018

I had the same experience as @peterhoeg.

@peterhoeg peterhoeg restored the f/sddmqt branch July 15, 2018 15:10
@peterhoeg peterhoeg deleted the f/sddmqt branch July 15, 2018 15:25
@ttuegel
Copy link
Member

ttuegel commented Jul 15, 2018

I cannot confirm that the original fix ever worked for me. I remember having the issue and trying out a few different things, only having things work when I manually blew away the cache, then running a version of unstable with your commit but still seeing the problem on the next upgrade.

Manually blowing away the cache directory worked every time though.

I'm sorry, I never knew that! It worked on my two machines. Thanks for taking care of this!

@peterhoeg
Copy link
Member Author

peterhoeg commented Jul 15, 2018 via email

@peterhoeg peterhoeg restored the f/sddmqt branch July 16, 2018 00:21
@peterhoeg peterhoeg deleted the f/sddmqt branch September 6, 2018 15:40
@peterhoeg peterhoeg restored the f/sddmqt branch September 6, 2018 15:58
@peterhoeg peterhoeg deleted the f/sddmqt branch October 8, 2018 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sddm: cannot login
6 participants
@peterhoeg @GrahamcOfBorg @jcrben @bkchr @ttuegel @worldofpeace