Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notify-osd-customizable: init at 0.9.35+16.04.20160415 #43226

Merged
merged 1 commit into from Aug 31, 2018
Merged

notify-osd-customizable: init at 0.9.35+16.04.20160415 #43226

merged 1 commit into from Aug 31, 2018

Conversation

colonelpanic8
Copy link
Contributor

@colonelpanic8 colonelpanic8 commented Jul 8, 2018 •
edited

Motivation for this change

The notify-osd that exists in nixpkgs is not customizable at all. This version allows the user configure notify-osd in ~/.notify-osd. Just for reference, the aur also has a separate version of notify-osd that is pulled from this PPA:

https://aur.archlinux.org/packages/notify-osd-customizable

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [N/A] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [N/A] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • [N/A new package] Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@colonelpanic8
Copy link
Contributor Author

do I need to request a reviewer?

@matthewbauer
Copy link
Member

@GrahamcOfBorg notify-osd-customizable

xeji
xeji reviewed Aug 25, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the package to pkgs/top-level/all-packages.nix, it's useless otherwise.

@ryantm
Copy link
Member

ryantm commented Aug 31, 2018

@GrahamcOfBorg notify-osd-customizable

@xeji
Copy link
Contributor

xeji commented Aug 31, 2018

@GrahamcOfBorg build notify-osd-customizable

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: notify-osd-customizable

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: notify-osd-customizable

Partial log (click to expand)

glibPreFixupPhase
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/j0qcm999fjyq69cyhgqfd8qbzaxzh05c-notify-osd-0.9.35+16.04.20160415
shrinking /nix/store/j0qcm999fjyq69cyhgqfd8qbzaxzh05c-notify-osd-0.9.35+16.04.20160415/bin/.notify-osd-wrapped
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j0qcm999fjyq69cyhgqfd8qbzaxzh05c-notify-osd-0.9.35+16.04.20160415/bin
patching script interpreter paths in /nix/store/j0qcm999fjyq69cyhgqfd8qbzaxzh05c-notify-osd-0.9.35+16.04.20160415
checking for references to /build in /nix/store/j0qcm999fjyq69cyhgqfd8qbzaxzh05c-notify-osd-0.9.35+16.04.20160415...
/nix/store/j0qcm999fjyq69cyhgqfd8qbzaxzh05c-notify-osd-0.9.35+16.04.20160415

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: notify-osd-customizable

Partial log (click to expand)

glibPreFixupPhase
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fzpv62a8l1kfrvpl7ay8dxhq3wxdqh6a-notify-osd-0.9.35+16.04.20160415
shrinking /nix/store/fzpv62a8l1kfrvpl7ay8dxhq3wxdqh6a-notify-osd-0.9.35+16.04.20160415/bin/.notify-osd-wrapped
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fzpv62a8l1kfrvpl7ay8dxhq3wxdqh6a-notify-osd-0.9.35+16.04.20160415/bin
patching script interpreter paths in /nix/store/fzpv62a8l1kfrvpl7ay8dxhq3wxdqh6a-notify-osd-0.9.35+16.04.20160415
checking for references to /build in /nix/store/fzpv62a8l1kfrvpl7ay8dxhq3wxdqh6a-notify-osd-0.9.35+16.04.20160415...
/nix/store/fzpv62a8l1kfrvpl7ay8dxhq3wxdqh6a-notify-osd-0.9.35+16.04.20160415

@xeji xeji merged commit 9a93fa2 into NixOS:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@colonelpanic8 @matthewbauer @ryantm @xeji @GrahamcOfBorg