Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

triggerhappy: init at 0.5.0 #43238

Merged
merged 1 commit into from Jul 11, 2018
Merged

triggerhappy: init at 0.5.0 #43238

merged 1 commit into from Jul 11, 2018

Conversation

tgharib
Copy link
Contributor

@tgharib tgharib commented Jul 9, 2018

Motivation for this change

Added triggerhappy hotkey daemon to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

postInstall = ''
install -D -m 644 -t "$out/etc/triggerhappy/triggers.d" "triggerhappy.conf.examples"
install -D -m 644 -t "$out/usr/lib/systemd/system" "systemd/triggerhappy.service" "systemd/triggerhappy.socket"
install -D -m 644 -T "udev/triggerhappy-udev.rules" "$out/usr/lib/udev/rules.d/97-triggerhappy.rules"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: It would be nice to use '-t' consistently. Otherwise it can quickly get confusion which file is copied to which directory.

@tgharib
Copy link
Contributor Author

tgharib commented Jul 11, 2018

@pSub Fixed

@pSub pSub merged commit 13f6400 into NixOS:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants