Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: Backports linux kernel 4.17 to 18.03 #43235

Merged
merged 7 commits into from Jul 9, 2018
Merged

linux: Backports linux kernel 4.17 to 18.03 #43235

merged 7 commits into from Jul 9, 2018

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Jul 8, 2018 •
edited

Motivation for this change

linuxPackages_latest was (understandably) downgraded from 4.16 to 4.14, since the 4.16 series isn't supported anymore.

The commit message was:

It would be nice to have 4.17, but ATM it won't build;
some changes in the (shared) kernel config would be needed.

Here I have backported with cherry-picked conflict-resolved the relevant commits to make 4.17 build for 18.03, and the relevant updates. Do tell if keeping the whole commit history cherry-picked is too much.

Testing done

I am currently dogfooding the use of 4.17 on 18.03 with this branch on my machine.

I don't know of NixOS tests that test linuxPackages_latest. I don't know either if one of tests can be used to test another kernel.

I have not tested most packages depending on the kernel, except the default settings + VirtualBox.

Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ✔️ NixOS
    • 🆖 macOS
    • ❌ other Linux distributions
  • ❓ Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • ❌ Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • 🆖 Tested execution of all binary files (usually in ./result/bin/)
  • ✔️ Determined the impact on package closure size (by running nix path-info -S before and after) new package, closure sizes goes from 0 to 66304848.
  • ✔️ Fits CONTRIBUTING.md.

@NeQuissimus @samueldr
linux: 4.16-rc7 -> 4.17-rc1
1069e32 
(cherry picked from commit f8665f1)

One file has been dropped from the commit:

```
 Conflicts:
	pkgs/os-specific/linux/kernel/linux-testing.nix
```
@NeQuissimus @samueldr
linux: Add 4.17
fe727a9 
(cherry picked from commit 3944456)

all-packages.nix differs in that only 4_17 has been added.
@NeQuissimus @samueldr
linux: 4.17 -> 4.17.1
97bf845 
(cherry picked from commit 91cda44)
@NeQuissimus @samueldr
linux: 4.17.1 -> 4.17.2
1aa59c4 
(cherry picked from commit 3afc706)
@NeQuissimus @samueldr
linux: 4.17.2 -> 4.17.3
01c9da0 
(cherry picked from commit 7dc31f5)
@NeQuissimus @samueldr
linux: 4.17.3 -> 4.17.4
3f72b14 
(cherry picked from commit ed8e468)
@NeQuissimus @samueldr
linux: 4.17.4 -> 4.17.5
7e65024 
(cherry picked from commit 0c69a75)
@xeji
Copy link
Contributor

xeji commented Jul 8, 2018

cc @vcunat

@samueldr samueldr mentioned this pull request Jul 8, 2018
Merged
@vcunat vcunat self-assigned this Jul 9, 2018
vcunat
vcunat approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK.

@vcunat vcunat merged commit 7e65024 into NixOS:release-18.03 Jul 9, 2018
vcunat added a commit that referenced this pull request Jul 9, 2018
@vcunat
Merge #43235: backport linux_4_17
d1eac65
@vcunat
Copy link
Member

vcunat commented Jul 9, 2018

Thanks, I haven't noticed the first commit you picked and gave up too soon, assuming noone would want such a new kernel on 18.03.

/cc @NeQuissimus: for backports of future 4.17 bumps.

@Baughn
Copy link
Contributor

Baughn commented Jul 9, 2018 •
edited

There are definitely some who would. Keep in mind, some of the hardware support for Ryzen/Zen CPUs (working around the C-state bug, etc.) was only mainlined in 4.17.

@samueldr samueldr mentioned this pull request Jul 9, 2018
Closed
@vcunat
Copy link
Member

vcunat commented Jul 9, 2018 •
edited

Ah, right. I even have an occasionally problematic Ryzen on 18.03 :-) but I think I'm mostly hitting those compilation crashes and not the C-state problem.

@xeji xeji mentioned this pull request Jul 10, 2018
Merged
@Baughn
Copy link
Contributor

Baughn commented Jul 13, 2018

The compilation crashes were due to marginal CPUs that have been recalled... you should talk to AMD, they'll let you swap it for a new one.

@vcunat
Copy link
Member

vcunat commented Jul 13, 2018

I had heard that, and I'll do that in the end, I guess. (I assume I'll have to go through the seller where it might be difficult to explain.) I had long been hoping for a fix in firmware or similar.

@samueldr samueldr deleted the backport/kernel-4.17 branch July 30, 2018 02:04
@samueldr samueldr mentioned this pull request Nov 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@samueldr @xeji @vcunat @Baughn @GrahamcOfBorg @NeQuissimus