New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openblas: backport fix #43234
openblas: backport fix #43234
Conversation
Failure on x86_64-linux (full log) Attempted: openblas Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: openblas Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: openblas Partial log (click to expand)
|
Failures are dependency failures/timeouts. |
patches = []; # TODO: Remove on next mass-rebuild | ||
patches = [ | ||
(fetchpatch { | ||
url = "https://github.com/xianyi/OpenBLAS/pull/1667.patch"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't the contents change once someone pushes an update to the PR? I know it's been merged, but still.
The following should be stable:
https://github.com/xianyi/OpenBLAS/commit/5f2a3c05cd0e3872be3c5686b9da6b627658eeb7.patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but since its merged I considered that safe. I'll change it though.
A little rant: Github didn't notify me about this review. Just swallowed the notification. I was just about to ask for a review when I saw it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the link. The reason I initially chose the /pull/1667.patch
format is that conveniently doubles as information about the source. But a comment is better for that anyways.
OpenMathLib/OpenBLAS#1666 Causing test failures in cvxopt and (according to an openblas issue) numpy.
ddfacb9
to
d2f0fc1
Compare
Success on x86_64-linux (full log) Attempted: openblas Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: openblas Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: openblas Partial log (click to expand)
|
Motivation for this change
OpenMathLib/OpenBLAS#1666
Causing test failures in cvxopt and (according to an openblas issue) numpy.
Also see cvxopt/cvxopt#122.
@ttuegel
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)