virtualbox: 5.2.8 -> 5.2.12 (18.03) #43237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes NixOS#39182. (cherry picked from commit 8eb3167)
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/virtualbox/versions. These checks were done: - built on NixOS - ran ‘/nix/store/6769l9s88jlcv3qgxpjsfr1ybkq3yvvb-virtualbox-5.2.12/bin/VBoxManage -h’ got 0 exit code - ran ‘/nix/store/6769l9s88jlcv3qgxpjsfr1ybkq3yvvb-virtualbox-5.2.12/bin/VBoxManage --help’ got 0 exit code - ran ‘/nix/store/6769l9s88jlcv3qgxpjsfr1ybkq3yvvb-virtualbox-5.2.12/bin/VBoxManage help’ got 0 exit code - ran ‘/nix/store/6769l9s88jlcv3qgxpjsfr1ybkq3yvvb-virtualbox-5.2.12/bin/VBoxBalloonCtrl -h’ got 0 exit code - ran ‘/nix/store/6769l9s88jlcv3qgxpjsfr1ybkq3yvvb-virtualbox-5.2.12/bin/VBoxBalloonCtrl --help’ got 0 exit code - found 5.2.12 with grep in /nix/store/6769l9s88jlcv3qgxpjsfr1ybkq3yvvb-virtualbox-5.2.12 - directory tree listing: https://gist.github.com/f9bf852a0a8e6e0b4c44a9b68764850b (cherry picked from commit 2c591d6)
(cherry picked from commit b6708a4)
|
@GrahamcOfBorg build virtualbox linuxPackages.virtualbox |
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: virtualbox, linuxPackages.virtualbox Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: virtualbox, linuxPackages.virtualbox Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: virtualbox, linuxPackages.virtualbox Partial log (click to expand)
|
|
@GrahamcOfBorg test virtualbox.simple-gui |
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: tests.virtualbox.simple-gui Partial log (click to expand)
|
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: tests.virtualbox.simple-gui Partial log (click to expand)
|
|
ofborg eval error for x86_64-linux looks unrelated. |
xeji
approved these changes
Jul 9, 2018
|
Indeed, it's reporting an assertion failure in assert builtins.langVersion >= 5;So I'd guess the ofborg builder needs a Nix update or something? :) |
|
Looks like it. Strange. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Backports VirtualBox 5.2.12 through cherry-picks since it is required for using under kernel 4.17.
Furthermore, having up-to-date software like VirtualBox seems like a good idea.
Things done
Dogfooding it here!
Tested it works both under 4.14 and 4.17.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)