Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncplay: 1.5.3 -> 1.5.5 #43245

Merged
merged 1 commit into from Jul 9, 2018
Merged

syncplay: 1.5.3 -> 1.5.5 #43245

merged 1 commit into from Jul 9, 2018

Conversation

Enzime
Copy link
Member

@Enzime Enzime commented Jul 9, 2018 •
edited

Leave syncplay to install to the correct directory rather than moving
folders around to make it work.

Motivation for this change

Update the latest version of syncplay as well as using PREFIX instead of DESTDIR to ensure syncplay installs everything correctly. Previously, the resources would be in the wrong folder and no icons would show in syncplay.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @ryantm

replaces #43155

@Enzime
syncplay: 1.5.3 -> 1.5.5
9d07953 
Leave syncplay to install to the correct directory rather than moving
folders around to make it work.
@xeji
Copy link
Contributor

xeji commented Jul 9, 2018

@GrahamcOfBorg build syncplay

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: syncplay

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: syncplay

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/g3f74z1bszarhgwi24xf2hsg2x2lz2vw-syncplay-1.5.5/lib  /nix/store/g3f74z1bszarhgwi24xf2hsg2x2lz2vw-syncplay-1.5.5/bin
patching script interpreter paths in /nix/store/g3f74z1bszarhgwi24xf2hsg2x2lz2vw-syncplay-1.5.5
/nix/store/g3f74z1bszarhgwi24xf2hsg2x2lz2vw-syncplay-1.5.5/bin/syncplay-server: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/fh8z4sniyv18b4jf32f3gnn862bvwc3f-python-2.7.15/bin/python2"
/nix/store/g3f74z1bszarhgwi24xf2hsg2x2lz2vw-syncplay-1.5.5/bin/syncplay: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/fh8z4sniyv18b4jf32f3gnn862bvwc3f-python-2.7.15/bin/python2"
/nix/store/g3f74z1bszarhgwi24xf2hsg2x2lz2vw-syncplay-1.5.5/lib/syncplay/syncplayServer.py: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/fh8z4sniyv18b4jf32f3gnn862bvwc3f-python-2.7.15/bin/python2"
/nix/store/g3f74z1bszarhgwi24xf2hsg2x2lz2vw-syncplay-1.5.5/lib/syncplay/syncplayClient.py: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/fh8z4sniyv18b4jf32f3gnn862bvwc3f-python-2.7.15/bin/python2"
checking for references to /build in /nix/store/g3f74z1bszarhgwi24xf2hsg2x2lz2vw-syncplay-1.5.5...
wrapping `/nix/store/g3f74z1bszarhgwi24xf2hsg2x2lz2vw-syncplay-1.5.5/bin/syncplay'...
wrapping `/nix/store/g3f74z1bszarhgwi24xf2hsg2x2lz2vw-syncplay-1.5.5/bin/syncplay-server'...
/nix/store/g3f74z1bszarhgwi24xf2hsg2x2lz2vw-syncplay-1.5.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: syncplay

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/anaci0d89lnlhzb3sfi73lql4b7vbsbj-syncplay-1.5.5/lib  /nix/store/anaci0d89lnlhzb3sfi73lql4b7vbsbj-syncplay-1.5.5/bin
patching script interpreter paths in /nix/store/anaci0d89lnlhzb3sfi73lql4b7vbsbj-syncplay-1.5.5
/nix/store/anaci0d89lnlhzb3sfi73lql4b7vbsbj-syncplay-1.5.5/lib/syncplay/syncplayClient.py: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/d3aa78jf7pm9lk6ad67x4f21a068dxn6-python-2.7.15/bin/python2"
/nix/store/anaci0d89lnlhzb3sfi73lql4b7vbsbj-syncplay-1.5.5/lib/syncplay/syncplayServer.py: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/d3aa78jf7pm9lk6ad67x4f21a068dxn6-python-2.7.15/bin/python2"
/nix/store/anaci0d89lnlhzb3sfi73lql4b7vbsbj-syncplay-1.5.5/bin/syncplay-server: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/d3aa78jf7pm9lk6ad67x4f21a068dxn6-python-2.7.15/bin/python2"
/nix/store/anaci0d89lnlhzb3sfi73lql4b7vbsbj-syncplay-1.5.5/bin/syncplay: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/d3aa78jf7pm9lk6ad67x4f21a068dxn6-python-2.7.15/bin/python2"
checking for references to /build in /nix/store/anaci0d89lnlhzb3sfi73lql4b7vbsbj-syncplay-1.5.5...
wrapping `/nix/store/anaci0d89lnlhzb3sfi73lql4b7vbsbj-syncplay-1.5.5/bin/syncplay-server'...
wrapping `/nix/store/anaci0d89lnlhzb3sfi73lql4b7vbsbj-syncplay-1.5.5/bin/syncplay'...
/nix/store/anaci0d89lnlhzb3sfi73lql4b7vbsbj-syncplay-1.5.5

@xeji xeji merged commit e64b114 into NixOS:master Jul 9, 2018
@xeji xeji mentioned this pull request Jul 9, 2018
Closed
@Enzime Enzime deleted the update/syncplay branch July 14, 2018 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Enzime @xeji @GrahamcOfBorg