gtkspell3: add valaSupport #43129
Merged
gtkspell3: add valaSupport #43129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Jul 7, 2018
| @@ -1,4 +1,4 @@ | |||
| {stdenv, fetchurl, gtk3, aspell, pkgconfig, enchant, isocodes, intltool, gobjectIntrospection}: | |||
| {stdenv, fetchurl, gtk3, aspell, pkgconfig, enchant, isocodes, intltool, gobjectIntrospection, valaSupport ? true, vala_0_40}: | |||
There was a problem hiding this comment.
Let's just build it always with vala support, it should be pretty small and go to dev output anyway.
There was a problem hiding this comment.
@jtojnar Did the thing
jtojnar
reviewed
Jul 7, 2018
| configureFlags = [ "--enable-introspection" ]; | ||
| configureFlags = [ | ||
| "--enable-introspection" | ||
| "--enable-vala=yes" |
There was a problem hiding this comment.
You can get rid of the yes here too.
| @@ -11,11 +11,14 @@ stdenv.mkDerivation rec { | |||
| sha256 = "09jdicmpipmj4v84gnkqwbmj4lh8v0i6pn967rb9jx4zg2ia9x54"; | |||
| }; | |||
|
|
|||
| nativeBuildInputs = [ pkgconfig intltool gobjectIntrospection ]; | |||
| nativeBuildInputs = [ pkgconfig intltool gobjectIntrospection vala_0_40 ]; | |||
There was a problem hiding this comment.
I would just use vala here. It is backwards compatible most of the time and updating every file when new version is released is annoying.
|
@GrahamcOfBorg build gtkspell3 |
|
Success on x86_64-linux (full log) Attempted: gtkspell3 Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: gtkspell3 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gtkspell3 Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I was packaging elementary-code and it cried about gtkspell3 not having vala support.
cc @jtojnar
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)