Remove leftover debug messages in raise.cr #6343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
reviewed
Jul 6, 2018
|
what about wrapping them in a debug conditional? |
|
I struggled with exceptions on ARM and damn, they helped a lot. Keep 'em in, commented, because they're useless to 99.99% of users they'd just clutter the compiler with macros for each and every compilation. |
|
I think this is fine as-is |
|
@ysbaddaden makes sense, just one question: why they are more useful on |
|
Because when raise breaks it's harder to debug. And raise breaks quite often (for example - it's broken on windows right now) |
|
Thanks for clarifying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA