Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkmanagerapplet: 1.8.10 -> 1.8.14 #43123

Closed
wants to merge 1 commit into from
Closed

networkmanagerapplet: 1.8.10 -> 1.8.14 #43123

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 6, 2018

https://gitlab.gnome.org/GNOME/network-manager-applet/blob/1.8.14/NEWS
(includes 1.8.12 changes as well)

In particular after nixos-rebuild'ing against master,
I found nm-applet (1.8.10) crashed regularly when trying to connect to my VPN.

Update seems to fix this behavior. \o/

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Jul 6, 2018

Oh and the change to the appindicator flag is in response to build failing otherwise, complaining valid options were... well, here's what it printed:

  meson.build:234:2: ERROR:  Problem encountered: Options allowed for -Dappindicator=<str> are: no, yes|auto, ayatana, ubuntu.

@dtzWill dtzWill mentioned this pull request Jul 6, 2018
Closed
@dtzWill dtzWill requested a review from jtojnar July 6, 2018 16:57
@jtojnar
Copy link
Contributor

jtojnar commented Jul 6, 2018

Already included in #43087

@dtzWill
Copy link
Member Author

dtzWill commented Jul 6, 2018

Oh! Well great! If that ends up being stalled I'd like to merge this (since it fixes crashing behavior for me and possibly others) but upgrading the nm stack sounds good too! Will close in favor of that, sorry I missed that it was included!

@dtzWill dtzWill closed this Jul 6, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: networkmanagerapplet

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/a3v3m71kcaqs6956c5g1ss7falmp1h7w-network-manager-applet-1.8.14-dev
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a3v3m71kcaqs6956c5g1ss7falmp1h7w-network-manager-applet-1.8.14-dev/lib
patching script interpreter paths in /nix/store/a3v3m71kcaqs6956c5g1ss7falmp1h7w-network-manager-applet-1.8.14-dev
checking for references to /build in /nix/store/a3v3m71kcaqs6956c5g1ss7falmp1h7w-network-manager-applet-1.8.14-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/xis9pw22b82w58hvgvgzzgh7dixn1m3x-network-manager-applet-1.8.14-devdoc
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/xis9pw22b82w58hvgvgzzgh7dixn1m3x-network-manager-applet-1.8.14-devdoc
checking for references to /build in /nix/store/xis9pw22b82w58hvgvgzzgh7dixn1m3x-network-manager-applet-1.8.14-devdoc...
/nix/store/mrc8qmvsm6ap9k2dym2112sy6bdbzsik-network-manager-applet-1.8.14

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: networkmanagerapplet

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/bn3m678d9b1cz6gpsqvdk7d0qq3jggjg-network-manager-applet-1.8.14-dev
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bn3m678d9b1cz6gpsqvdk7d0qq3jggjg-network-manager-applet-1.8.14-dev/lib
patching script interpreter paths in /nix/store/bn3m678d9b1cz6gpsqvdk7d0qq3jggjg-network-manager-applet-1.8.14-dev
checking for references to /build in /nix/store/bn3m678d9b1cz6gpsqvdk7d0qq3jggjg-network-manager-applet-1.8.14-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/7sby93dsrh9q1cxkxnsw4psm9j5dzlis-network-manager-applet-1.8.14-devdoc
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/7sby93dsrh9q1cxkxnsw4psm9j5dzlis-network-manager-applet-1.8.14-devdoc
checking for references to /build in /nix/store/7sby93dsrh9q1cxkxnsw4psm9j5dzlis-network-manager-applet-1.8.14-devdoc...
/nix/store/x9aws9k4v1kivvsvi555qx23gxwj2ch7-network-manager-applet-1.8.14

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: networkmanagerapplet

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@dtzWill dtzWill mentioned this pull request Jul 9, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @jtojnar @GrahamcOfBorg