Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintainers/scripts/update-python-libraries: compare versions semantically instead of lexicographically #43120

Merged
merged 1 commit into from Jul 6, 2018
Merged

maintainers/scripts/update-python-libraries: compare versions semantically instead of lexicographically #43120

merged 1 commit into from Jul 6, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

I just had the case that an update 0.9.9 -> 0.9.10 was available, but regarded as a downgrade by the script.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from FRidh as a code owner July 6, 2018 15:13
@xeji
Copy link
Contributor

xeji commented Jul 6, 2018

yet another classic bug 👍

@xeji xeji merged commit 7a59be9 into NixOS:master Jul 6, 2018
@dotlambda
Copy link
Member Author

@FRidh Please quickly comfirm when you have taken notice of this.

@FRidh
Copy link
Member

FRidh commented Jul 10, 2018

Looks good, thanks.

@dotlambda dotlambda deleted the update-python-compare-semver branch January 17, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @xeji @FRidh @GrahamcOfBorg