cargo-download: init at 0.1.1 #44978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo.nix was generated from cargo-download 0.1.1 with this patch applied, which was necessary to not confuse carnix about the version being different between Cargo.toml and Cargo.lock. See Xion/cargo-download#3. From 5efd4cf11ff9d5042712303404169016b1e05c33 Mon Sep 17 00:00:00 2001 From: Alyssa Ross <hi@alyssa.is> Date: Thu, 26 Jul 2018 21:19:06 +0200 Subject: [PATCH] Fix Cargo.lock Running `cargo build` on a clean checkout produces a diff in Cargo.lock, because it wasn't updated after the version number was bumped. After this commit, `cargo build` should no longer produce a modified working tree. --- Cargo.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Cargo.lock b/Cargo.lock index cc7357c..c384dc1 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -76,7 +76,7 @@ dependencies = [ [[package]] name = "cargo-download" -version = "0.1.0" +version = "0.1.1" dependencies = [ "ansi_term 0.9.0 (registry+https://github.com/rust-lang/crates.io-index)", "clap 2.27.1 (registry+https://github.com/rust-lang/crates.io-index)", -- 2.17.1
xeji
reviewed
Sep 1, 2018
|
|
||
| ((import ./Cargo.nix { inherit lib buildPlatform buildRustCrate fetchgit; }).cargo_download {}).override { | ||
|
|
||
| } |
There was a problem hiding this comment.
Nevermind, I see that's what the examples in the manual are structured like...
|
@GrahamcOfBorg build cargo-download |
|
Success on aarch64-linux (full log) Attempted: cargo-download Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: cargo-download Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: cargo-download Partial log (click to expand)
|
|
Some missing frameworks for Darwin. Unless you have a Mac this may be a few rounds of trial-and-error with ofborg because Security depends on other frameworks etc. You can try to fix it or just limit platforms to linux. Up to you. |
|
I have a Mac :) |
|
@GrahamcOfBorg build cargo-download |
alyssais
commented
Sep 4, 2018
| ((import ./Cargo.nix { inherit lib buildPlatform buildRustCrate fetchgit; }).cargo_download {}).override { | ||
| crateOverrides = defaultCrateOverrides // { | ||
| cargo-download = attrs: { | ||
| buildInputs = lib.optional stdenv.isDarwin |
There was a problem hiding this comment.
I noticed that cargo-edit used a propagatedBuildInput for Security. I wasn't sure if I should be doing the same here. Should I be?
There was a problem hiding this comment.
Sorry, don't know too much about how the Darwin frameworks work.
If it works for you on a Mac it should be ok.
|
Success on aarch64-linux (full log) Attempted: cargo-download Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: cargo-download Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: cargo-download Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo.nix was generated from cargo-download 0.1.1 with this patch applied, which was necessary to not confuse carnix about the version being different between Cargo.toml and Cargo.lock.
See Xion/cargo-download#3.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)