mimic: init at 1.2.0.2 #44961
Merged
mimic: init at 1.2.0.2 #44961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pSub
requested changes
Aug 13, 2018
| homepage = https://mimic.mycroft.ai/; | ||
| license = stdenv.lib.licenses.free; | ||
| platforms = stdenv.lib.platforms.linux; | ||
| maintainers = [ "Andy Chun <andy@lolc.at>" ]; |
There was a problem hiding this comment.
Please add yourself to maintainers/maintainers-list.nix instead.
infinisil
reviewed
Aug 13, 2018
| version = "1.2.0.2"; | ||
|
|
||
| src = fetchFromGitHub { | ||
| rev = "${version}"; |
There was a problem hiding this comment.
rev = "${version}" -> rev = version
GrahamcOfBorg
added
2.status: merge conflict
and removed
2.status: merge conflict
labels
pSub
approved these changes
Aug 15, 2018
|
Could you rebase your changes instead of doing a merge commit? |
infinisil
reviewed
Aug 15, 2018
maintainers/maintainer-list.nix
Outdated
| email = "nonfreeblob@yandex.com"; | ||
| github = "nonfreeblob"; | ||
| name = "nonfreeblob"; | ||
| }; |
There was a problem hiding this comment.
This needs to be fixed now too, merge conflict resolved wrongly.
|
@pSub @infinisil Whoops, sure thing. |
infinisil
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Addition of
mimic, Mycroft's TTS engine. Includes an executable and apkgconfiglibraryThings done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)