Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/qemu-vm: Don't explicitly mknod /dev/vda* #44938

Closed
wants to merge 2 commits into from
Closed

nixos/qemu-vm: Don't explicitly mknod /dev/vda* #44938

wants to merge 2 commits into from

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Aug 12, 2018 •
edited

Motivation for this change

Partially addresses #44918

The device node already exists, causing the mknod call to fail.

The actual vm is still not bootable, but that failure seems to be unrelated,

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor Author

srhb commented Aug 12, 2018

Don't merge this just yet, the "fixes" is very speculative, since I haven't been able to boot a vm with this just yet...

@srhb
Copy link
Contributor Author

srhb commented Aug 16, 2018

I don't have time to look into this right now, as it got more complex. I'll close for now so as to not keep peoples' hope up.

@srhb srhb closed this Aug 16, 2018
@dezgeg
Copy link
Contributor

dezgeg commented Aug 16, 2018

Well at least the changes here so far sound ObviouslyCorrect to me, so they could be merged regardless of not being a full fix to the original problem.

@srhb srhb reopened this Aug 16, 2018
@srhb
Copy link
Contributor Author

srhb commented Aug 16, 2018

@dezgeg That's a good point. Thanks.

@dezgeg
Copy link
Contributor

dezgeg commented Aug 16, 2018

@GrahamcOfBorg test simple

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.simple

Partial log (click to expand)

machine# [    5.977875] systemd-shutdown[1]: Detaching DM devices.
machine# [    5.981175] ACPI: Preparing to enter system sleep state S5
machine# [    5.982053] reboot: Power down
vde_switch: EOF data port: Interrupted system call
collecting coverage data
syncing
test script finished in 7.07s
vde_switch: EOF on stdin, cleaning up and exiting
cleaning up
/nix/store/b8xnwj1niiz3bd1c1c6vzc78r0zbf6hr-vm-test-run-simple

@dezgeg
Copy link
Contributor

dezgeg commented Aug 16, 2018

I squashed them in and noted in the commit message why these no longer need to be created. 78fb4bd

@dezgeg dezgeg closed this Aug 16, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.simple

Partial log (click to expand)

machine# [   19.568308] systemd-shutdown[1]: All loop devices detached.
machine# [   19.572632] systemd-shutdown[1]: Detaching DM devices.
machine# [   19.596746] reboot: Power down
vde_switch: EOF data port: Interrupted system call
collecting coverage data
syncing
test script finished in 20.39s
vde_switch: EOF on stdin, cleaning up and exiting
cleaning up
/nix/store/s1rs7fcmvwphskrgk348fzyva136brpa-vm-test-run-simple

@srhb srhb deleted the qemu-vm-dont-mknod branch August 16, 2018 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @dezgeg @GrahamcOfBorg