nixos/gitea: fix pre start script #44979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had one problem, the |
|
Should be fixed now |
|
I'm not sure if it's relevant to this PR, but I'm running gitea on nixos 18.03 and currently, it's failing to start with this error message: |
|
@uvNikita yes, this PR fix exactly this. For a quick fix you can run the command manually. |
|
This feature fixes exactly this error.Am 23.08.2018 10:00 schrieb Nikita Uvarov <notifications@github.com>:I'm not sure if it's relevant to this PR, but I'm running gitea on nixos 18.03 and currently, it's failing to start with this error message:
panic: fail to set message file(uk-UA): open conf/locale/locale_uk-UA.ini: no such file or directory
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Great! Thanks for the explanation, I'll try to run the command manually for now. |
|
Merge conflict because a similar fix was merged in #45608. I'm afraid this PR (which was first) was overlooked. Please close it if the issue is fixed now. Thank you for contributing! |
The gitea path is hardcoded in hooks directory in files of paths like:
repositories/<user>/<repo>.git/hooks/update.d/gitea
|
Ah okay, I have updated the PR accordingly. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The gitea path is hardcoded in hooks directory in files of paths like:
The locales can be updated on a new gitea release and therefore should be updated in the
stateDir.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)