Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libimobiledevice updates #44966

Merged
merged 6 commits into from Aug 15, 2018
Merged

libimobiledevice updates #44966

merged 6 commits into from Aug 15, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Obscene package versions mostly :)

This should give function to devices with newer IOS versions.

Also #40952 is partially finished (no longer outdated) but they still are without a maintainer.

Testing with new devices would be nice and always kind reviewers 馃憤

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Aug 14, 2018

@GrahamcOfBorg build usbmuxd libusbmuxd libimobiledevice ifuse gtkpod

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: usbmuxd, libusbmuxd, libimobiledevice, ifuse, gtkpod

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: usbmuxd, libusbmuxd, libimobiledevice, ifuse, gtkpod

Partial log (click to expand)

gzipping man pages under /nix/store/7pg6q5hz12xkbga366nplrjkbp883bj2-ifuse-1.1.3/share/man/
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7pg6q5hz12xkbga366nplrjkbp883bj2-ifuse-1.1.3/bin
patching script interpreter paths in /nix/store/7pg6q5hz12xkbga366nplrjkbp883bj2-ifuse-1.1.3
checking for references to /build in /nix/store/7pg6q5hz12xkbga366nplrjkbp883bj2-ifuse-1.1.3...
/nix/store/ldz796ifkhc3xynb4kspxlk0b3rnq5cw-usbmuxd-2018-07-22
/nix/store/byb2k2mqpcfdsb79cvdddqavr24qc8w5-libusbmuxd-2018-07-23
/nix/store/jz71vvvh3a0jd4gcsj3pf0zlb9fz0wj5-libimobiledevice-2018-07-24
/nix/store/7pg6q5hz12xkbga366nplrjkbp883bj2-ifuse-1.1.3
/nix/store/w59vc101bhnn8sxj73mh5lq0d7dc0p8i-gtkpod-2.1.5

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: usbmuxd, libusbmuxd, libimobiledevice, ifuse, gtkpod

Partial log (click to expand)

rmdir: failed to remove '/nix/store/7gx7jjp4a0bc16iw7jjdvg6cppcyfd34-libgpod-0.8.3/share': Directory not empty
shrinking RPATHs of ELF executables and libraries in /nix/store/7gx7jjp4a0bc16iw7jjdvg6cppcyfd34-libgpod-0.8.3
shrinking /nix/store/7gx7jjp4a0bc16iw7jjdvg6cppcyfd34-libgpod-0.8.3/bin/ipod-read-sysinfo-extended
shrinking /nix/store/7gx7jjp4a0bc16iw7jjdvg6cppcyfd34-libgpod-0.8.3/lib/udev/iphone-set-info
shrinking /nix/store/7gx7jjp4a0bc16iw7jjdvg6cppcyfd34-libgpod-0.8.3/lib/udev/ipod-set-info
shrinking /nix/store/7gx7jjp4a0bc16iw7jjdvg6cppcyfd34-libgpod-0.8.3/lib/libgpod.so.4.3.2
patching script interpreter paths in /nix/store/7gx7jjp4a0bc16iw7jjdvg6cppcyfd34-libgpod-0.8.3
checking for references to /build in /nix/store/7gx7jjp4a0bc16iw7jjdvg6cppcyfd34-libgpod-0.8.3...
cannot build derivation '/nix/store/kx1i0cf3ag33xjzp1nbj0y1apbbyjvcx-gtkpod-2.1.5.drv': 1 dependencies couldn't be built
error: build of '/nix/store/kx1i0cf3ag33xjzp1nbj0y1apbbyjvcx-gtkpod-2.1.5.drv' failed

@infinisil
Copy link
Member

Hold on, I'll test whether the usbmuxd service still works, it's responsible for tethering with iPhones

infinisil
infinisil approved these changes Aug 14, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, still works just fine

@infinisil
Copy link
Member

ifuse also works with my iPhone 6 Plus

@worldofpeace
Copy link
Contributor Author

@infinisil Did you device have like IOS > 11.x?

@infinisil
Copy link
Member

@worldofpeace Nah, only 10.3.3 (I don't want to update because it's already very sluggish, the update probably just makes it worse).

If we can't find somebody with 11.x in a few days I say let's just merge it.

@worldofpeace
Copy link
Contributor Author

@infinisil I tested it with 11.x and it works 馃憤

infinisil
infinisil approved these changes Aug 15, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@infinisil infinisil merged commit b1cf86b into NixOS:master Aug 15, 2018
@worldofpeace worldofpeace deleted the imobile-updates branch August 15, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @Mic92 @GrahamcOfBorg @infinisil