Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm-gc: init at 0.1.6 #44968

Merged
merged 1 commit into from Sep 23, 2018
Merged

wasm-gc: init at 0.1.6 #44968

merged 1 commit into from Sep 23, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Aug 13, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wasm-gc

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1wcil2g6fcik51dl9a4r8v81sppw739f-wasm-gc-0.1.6
shrinking /nix/store/1wcil2g6fcik51dl9a4r8v81sppw739f-wasm-gc-0.1.6/bin/wasm-gc
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1wcil2g6fcik51dl9a4r8v81sppw739f-wasm-gc-0.1.6/bin
patching script interpreter paths in /nix/store/1wcil2g6fcik51dl9a4r8v81sppw739f-wasm-gc-0.1.6
checking for references to /build in /nix/store/1wcil2g6fcik51dl9a4r8v81sppw739f-wasm-gc-0.1.6...
/nix/store/1wcil2g6fcik51dl9a4r8v81sppw739f-wasm-gc-0.1.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: wasm-gc

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q7zglljw5idpfvyqqn4hq3v5s2dblyrz-wasm-gc-0.1.6
shrinking /nix/store/q7zglljw5idpfvyqqn4hq3v5s2dblyrz-wasm-gc-0.1.6/bin/wasm-gc
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q7zglljw5idpfvyqqn4hq3v5s2dblyrz-wasm-gc-0.1.6/bin
patching script interpreter paths in /nix/store/q7zglljw5idpfvyqqn4hq3v5s2dblyrz-wasm-gc-0.1.6
checking for references to /build in /nix/store/q7zglljw5idpfvyqqn4hq3v5s2dblyrz-wasm-gc-0.1.6...
/nix/store/q7zglljw5idpfvyqqn4hq3v5s2dblyrz-wasm-gc-0.1.6

@Ekleog Ekleog force-pushed the wasm-gc-init branch 2 times, most recently from ec1abe5 to 810025f Compare August 13, 2018 13:08
@Ekleog Ekleog mentioned this pull request Aug 13, 2018
Merged
9 tasks
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wasm-gc

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/njsq2qb85npscap909kg5h1l06xmam9r-wasm-gc-0.1.6
shrinking /nix/store/njsq2qb85npscap909kg5h1l06xmam9r-wasm-gc-0.1.6/bin/wasm-gc
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/njsq2qb85npscap909kg5h1l06xmam9r-wasm-gc-0.1.6/bin
patching script interpreter paths in /nix/store/njsq2qb85npscap909kg5h1l06xmam9r-wasm-gc-0.1.6
checking for references to /build in /nix/store/njsq2qb85npscap909kg5h1l06xmam9r-wasm-gc-0.1.6...
/nix/store/njsq2qb85npscap909kg5h1l06xmam9r-wasm-gc-0.1.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: wasm-gc

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zad95c8jqqxvsc2x0l5xk67xzjgd406r-wasm-gc-0.1.6
shrinking /nix/store/zad95c8jqqxvsc2x0l5xk67xzjgd406r-wasm-gc-0.1.6/bin/wasm-gc
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zad95c8jqqxvsc2x0l5xk67xzjgd406r-wasm-gc-0.1.6/bin
patching script interpreter paths in /nix/store/zad95c8jqqxvsc2x0l5xk67xzjgd406r-wasm-gc-0.1.6
checking for references to /build in /nix/store/zad95c8jqqxvsc2x0l5xk67xzjgd406r-wasm-gc-0.1.6...
/nix/store/zad95c8jqqxvsc2x0l5xk67xzjgd406r-wasm-gc-0.1.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wasm-gc

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/26sl2pfa9zdpfpkvdf2nwpd6wyfrgijk-wasm-gc-0.1.6
shrinking /nix/store/26sl2pfa9zdpfpkvdf2nwpd6wyfrgijk-wasm-gc-0.1.6/bin/wasm-gc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/26sl2pfa9zdpfpkvdf2nwpd6wyfrgijk-wasm-gc-0.1.6/bin
patching script interpreter paths in /nix/store/26sl2pfa9zdpfpkvdf2nwpd6wyfrgijk-wasm-gc-0.1.6
checking for references to /build in /nix/store/26sl2pfa9zdpfpkvdf2nwpd6wyfrgijk-wasm-gc-0.1.6...
/nix/store/26sl2pfa9zdpfpkvdf2nwpd6wyfrgijk-wasm-gc-0.1.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: wasm-gc

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/12ljq7nww9gkh1gs5zy3802wv5v63j3w-wasm-gc-0.1.6
shrinking /nix/store/12ljq7nww9gkh1gs5zy3802wv5v63j3w-wasm-gc-0.1.6/bin/wasm-gc
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/12ljq7nww9gkh1gs5zy3802wv5v63j3w-wasm-gc-0.1.6/bin
patching script interpreter paths in /nix/store/12ljq7nww9gkh1gs5zy3802wv5v63j3w-wasm-gc-0.1.6
checking for references to /build in /nix/store/12ljq7nww9gkh1gs5zy3802wv5v63j3w-wasm-gc-0.1.6...
/nix/store/12ljq7nww9gkh1gs5zy3802wv5v63j3w-wasm-gc-0.1.6

@srhb
Copy link
Contributor

srhb commented Sep 23, 2018

Why this version in particular? I notice that at the time this PR was made, several new versions were already released. Is this intentional?

@Ekleog
Copy link
Member Author

Ekleog commented Sep 23, 2018

My understanding of the tagging scheme is that the wasm-gc-api-* tags concern the API of wasm-gc (as usable from Rust), while the 0.1.6-like tags concern wasm-gc (the executable), in the same way that https://crates.io/crates/wasm-gc-api is 0.1.11 and https://crates.io/crates/wasm-gc is 0.1.6. :)

@srhb srhb merged commit 4445414 into NixOS:master Sep 23, 2018
@Ekleog
Copy link
Member Author

Ekleog commented Sep 23, 2018

Thanks! :)

@Ekleog Ekleog deleted the wasm-gc-init branch September 23, 2018 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ekleog @GrahamcOfBorg @srhb